ci: generate pre-built binaries for darwin and arm64 (backport #2654) #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Closes #2567 ## Testing Testing with binaries on [my fork](https://github.com/rootulp/celestia-app/releases/tag/v1.0.0-rc5). | os | arch | machine | works | notes | |--------|----------------|---------------|-------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | darwin | arm64 | Rootul's MBP | ✅ | I had to circumvent [Apple can't check app for malicious software](https://support.apple.com/guide/mac-help/apple-cant-check-app-for-malicious-software-mchleab3a043/mac) | | darwin | amd64 (x86_64) | AWS | ✅ | | | linux | arm64 | AWS | ✅ | | | linux | amd64 (x86_64) | Digital Ocean | ✅ | | (cherry picked from commit a692125)
mergify
bot
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
Codecov Report
@@ Coverage Diff @@
## v1.x #2662 +/- ##
=======================================
Coverage 20.41% 20.41%
=======================================
Files 140 140
Lines 15933 15933
=======================================
Hits 3252 3252
Misses 12373 12373
Partials 308 308 |
rootulp
approved these changes
Oct 11, 2023
cmwaters
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2654 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com