fix: nightly e2e workflow #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2670 +/- ##
=======================================
Coverage 21.11% 21.11%
=======================================
Files 138 138
Lines 15767 15767
=======================================
Hits 3329 3329
Misses 12115 12115
Partials 323 323 |
rootulp
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
[question] in https://github.com/celestiaorg/celestia-app/actions/runs/6688978782/job/18171816590#step:5:39 why is the v getting removed from version? Does this PR also fix that or is that a separate issue?
Yes this should fix it |
rach-id
approved these changes
Oct 30, 2023
evan-forbes
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow wasn't correctly pulling the latest version. This fixes that. It also updates the default to "latest"