Add back the governance module

[liamsi]

Description

Basically copy & paste everything gov related from a fresh starport app.

related to: #168

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[liamsi]

Let's discuss the community pool in a separate issue/github dicsussion thread. I'll remove the todo after we have that issue/discusssion.

[evan-forbes]

Yay! Thanks for adding this back in!

[evan-forbes]

whoops, sorry, reviewed my phone and got too excited. setting a block so we don't accidentally merge before we set the gov module account.

[liamsi]

before we set the gov module account

What do you mean?

[liamsi]

I think these are all the changes necessary to add back the governance module. While modifying the code, I've realized that we could restructure files/packages slightly to make it more readable/accessible. I think we can slowly move away from the way starport generates and structures everything. But that is orthogonal to this PR.

Either way, turning this into ready for review now.

[adlerjohn]

utACK

[evan-forbes]

👍

[evan-forbes]

fairly certain that the linter is only failing because of what was already fixed in #273

[evan-forbes]

While modifying the code, I've realized that we could restructure files/packages slightly to make it more readable/accessible.

I agree. I like what osmosis does here by separating the modules out into their own file. We could likely do this with even more components of the app.

https://github.com/osmosis-labs/osmosis/blob/main/app/modules.go

[liamsi]

fairly certain that the linter is only failing because of what was already fixed in #273

Let me rebase to be more certain :)

I like what osmosis does here by separating the modules out into their own file. We could likely do this with even more components of the app.

Yes, exactly. I also thought Osmosis was a good example here!

[liamsi]

fairly certain that the linter is only failing because of what was already fixed in #273

confirmed, thanks

[codecov-commenter]

Codecov Report

Merging #272 (453ba5c) into master (1850d85) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   25.74%   25.74%           
=======================================
  Files          12       12           
  Lines        1837     1837           
=======================================
  Hits          473      473           
  Misses       1326     1326           
  Partials       38       38           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67ae66f...453ba5c. Read the comment docs.

[adlerjohn]

utACK