-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): replace old qgb contracts repo with blobstream repo (backport #2709) #2720
Conversation
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview The dependencies part of #2639 ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords (cherry picked from commit c517bd2) # Conflicts: # go.mod # x/qgb/client/verify.go
I'm not sure that we sure backport this yet 🤔 the reason being that ideally we never backport any breaking changes, therefore we wouldn't backport the name changes to the vars. If we don't back port those then I'm not sure that we should update the constracts either. |
@evan-forbes This is changing only the dependency to depend on blobstream contracts, nothing more. no variable change is done. Also, this isn't breaking as nothing is being persisted or sent over the wire... should we explicitly test that this is not breaking? via running a node |
yeah that makes sense, but why update the contracts if we're not going to update the names on v1.x is what I'm saying |
actually no big reason, just not to have different versions in the app release and in the orchestrators-realyer, and end up with an I'm fine if we don't need to merge this |
Codecov Report
@@ Coverage Diff @@
## v1.x #2720 +/- ##
=======================================
Coverage 20.41% 20.41%
=======================================
Files 139 139
Lines 15927 15927
=======================================
Hits 3252 3252
Misses 12367 12367
Partials 308 308
|
Please re-open if we want / need this |
This is an automatic backport of pull request #2709 done by Mergify.
Cherry-pick of c517bd2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com