feat: query earliest attestation nonce #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
rach-id
added
the
backport:v1.x
rootulp
reviewed
Oct 19, 2023
| // LatestAttestationNonce queries latest attestation nonce. | ||
| rpc EarliestAttestationNonce(QueryEarliestAttestationNonceRequest) | ||
| returns (QueryEarliestAttestationNonceResponse) { | ||
| option (google.api.http).get = "/qgb/v1/attestations/nonce/earliest"; |
There was a problem hiding this comment.
[question] did the rename PR not include a rename to the endpoint?
I would expect /blockstream/v1 and not `/qgb/v1/
There was a problem hiding this comment.
that would be breaking, we wanted to keep that until v2
There was a problem hiding this comment.
to clarify the smallest bit, we want to add the consensus breaking things, but we first need the infra to be able to test the upgrade/migrations
Also, if we don't already have an issue for that, can we get one?
Codecov Report
@@ Coverage Diff @@
## main #2724 +/- ##
==========================================
- Coverage 19.89% 19.60% -0.30%
==========================================
Files 139 139
Lines 16695 16994 +299
==========================================
+ Hits 3322 3331 +9
- Misses 13051 13341 +290
Partials 322 322
|
Co-authored-by: Rootul P <[email protected]>
rootulp
previously approved these changes
Oct 19, 2023
evan-forbes
previously approved these changes
Oct 19, 2023
rootulp
approved these changes
Oct 19, 2023
evan-forbes
approved these changes
Oct 20, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview So that the orchestartor is able to query the earliest attestation nonce and sign up to it. This change is not breaking and is just adding a new API endpoint. PS: I originally thought that this was already implemented. But sadly, we didn't. ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: Rootul P <[email protected]> (cherry picked from commit a3e1da0) # Conflicts: # x/qgb/types/query.pb.go
rach-id
added a commit
that referenced
this pull request
Oct 20, 2023
This is an automatic backport of pull request #2724 done by [Mergify](https://mergify.com). Cherry-pick of a3e1da0 has failed: ``` On branch mergify/bp/v1.x/pr-2724 Your branch is up to date with 'origin/v1.x'. You are currently cherry-picking commit a3e1da0. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: app/test/qgb_rpc_test.go modified: proto/celestia/qgb/v1/query.proto modified: x/qgb/keeper/query_general.go modified: x/qgb/types/query.pb.gw.go Unmerged paths: (use "git add <file>..." to mark resolution) both modified: x/qgb/types/query.pb.go ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: CHAMI Rachid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
So that the orchestartor is able to query the earliest attestation nonce and sign up to it.
This change is not breaking and is just adding a new API endpoint.
PS: I originally thought that this was already implemented. But sadly, we didn't.
Checklist