Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(malicious): use constructor NMT options (backport #2723) #2743

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 20, 2023

This is an automatic backport of pull request #2723 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Reported by @vgonkivs who is working on a BEFP test and needs to pass
`nmt.NodeVisitor()` in to the malicious package's tree.

(cherry picked from commit 29a8925)
@celestia-bot celestia-bot requested a review from a team October 20, 2023 20:08
@github-actions github-actions bot added the bot item was created by a bot label Oct 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #2743 (ba15b01) into v1.x (aa54b9d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v1.x    #2743   +/-   ##
=======================================
  Coverage   20.09%   20.09%           
=======================================
  Files         139      139           
  Lines       16226    16226           
=======================================
  Hits         3261     3261           
  Misses      12657    12657           
  Partials      308      308           

@rootulp rootulp requested a review from staheri14 October 20, 2023 20:16
@evan-forbes evan-forbes enabled auto-merge (rebase) October 23, 2023 01:09
@evan-forbes evan-forbes merged commit 116da04 into v1.x Oct 23, 2023
24 of 25 checks passed
@evan-forbes evan-forbes deleted the mergify/bp/v1.x/pr-2723 branch October 23, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot item was created by a bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants