Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pre-built binary support for Ubuntu 20.04 (backport #2728) #2752

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 23, 2023

This is an automatic backport of pull request #2728 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

## Overview

I think this should fix #2727, I didn't see any docs to see how to
format the version specified for ubuntu

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

## Testing

Tested with
[celestia-app_Linux_x86_64.tar.gz](https://github.com/rootulp/celestia-app/releases/download/v1.0.0-rc7/celestia-app_Linux_x86_64.tar.gz)
created on
https://github.com/rootulp/celestia-app/releases/tag/v1.0.0-rc7

OS | Version | Works
--- | --- | ---
Ubuntu | 20.04 | ✅
Ubuntu | 23.04 | ✅

---------

Co-authored-by: Rootul Patel <[email protected]>
(cherry picked from commit 58f6c40)
@celestia-bot celestia-bot requested a review from a team October 23, 2023 16:22
@github-actions github-actions bot added the bot item was created by a bot label Oct 23, 2023
@evan-forbes evan-forbes enabled auto-merge (rebase) October 23, 2023 17:29
@evan-forbes evan-forbes merged commit 8a87e9d into v1.x Oct 23, 2023
24 of 25 checks passed
@evan-forbes evan-forbes deleted the mergify/bp/v1.x/pr-2728 branch October 23, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot item was created by a bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants