chore: disable API, GRPC, and GRPC web by default (backport #2761) #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Closes #2758 ## Testing ``` ./scripts/single-node.sh cat ~/.celestia-app/config/app.toml ``` Verified that ```toml [api] # Enable defines if the API server should be enabled. enable = false ``` ```toml [grpc] # Enable defines if the gRPC server should be enabled. enable = false ``` ```toml [grpc-web] # GRPCWebEnable defines if the gRPC-web should be enabled. # NOTE: gRPC must also be enabled, otherwise, this configuration is a no-op. enable = false ``` (cherry picked from commit b786b08)
mergify
bot
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
evan-forbes
approved these changes
Oct 25, 2023
Codecov Report
@@ Coverage Diff @@
## v1.x #2768 +/- ##
==========================================
+ Coverage 20.12% 20.20% +0.07%
==========================================
Files 139 139
Lines 16231 16237 +6
==========================================
+ Hits 3266 3280 +14
+ Misses 12657 12649 -8
Partials 308 308
|
rach-id
approved these changes
Oct 25, 2023
staheri14
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2761 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com