ci: add goreleaser-check as a require step for the goreleaser build (backport #2772) #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…2772) <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Minor update I saw when debugging the CI. This will ensure that the goreleaser step won't run if the goreleaser check fails. This will just clean up the error log a little bit. (cherry picked from commit 36ecb01)
mergify
bot
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
evan-forbes
previously approved these changes
Oct 27, 2023
|
I think we need to backport this? |
|
I think it's a "nice to have" but doesn't provide end-user benefit so it's subjective whether we backport or not. |
rootulp
previously approved these changes
Oct 27, 2023
rootulp
reviewed
Oct 31, 2023
|
Had to backport #2652 too |
rach-id
reviewed
Oct 31, 2023
Codecov Report
@@ Coverage Diff @@
## v1.x #2775 +/- ##
=======================================
Coverage 20.20% 20.20%
=======================================
Files 139 139
Lines 16237 16237
=======================================
Hits 3280 3280
Misses 12649 12649
Partials 308 308 |
|
IDK what you mean by won't be used for anything. The check added in this PR will run on subsequent PRs to v1.x. I don't expect many changes to the goreleaser config on v1.x but there will likely be at least one change related to fixing Ledger support on v1.x binaries. |
staheri14
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2772 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com