Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ledger support #2782

Merged
merged 4 commits into from
Oct 31, 2023
Merged

test: Ledger support #2782

merged 4 commits into from
Oct 31, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 29, 2023

Closes #2225

Note: this test won't fail when Goreleaser creates binaries that break Ledger support. However, this may catch when we bump a dependency that breaks Ledger support.

@rootulp rootulp added the testing items that are strictly related to adding or extending test coverage label Oct 29, 2023
@rootulp rootulp self-assigned this Oct 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

Merging #2782 (71f5154) into main (58b28cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2782   +/-   ##
=======================================
  Coverage   19.71%   19.71%           
=======================================
  Files         140      140           
  Lines       17015    17015           
=======================================
  Hits         3354     3354           
  Misses      13340    13340           
  Partials      321      321           

@rootulp
Copy link
Collaborator Author

rootulp commented Oct 29, 2023

lol this caught me forgetting to add test_ledger to the list of skipped tests for make test-short @cmwaters

@rootulp rootulp marked this pull request as ready for review October 29, 2023 12:49
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rootulp rootulp requested review from staheri14 and rach-id October 31, 2023 10:08
@rootulp rootulp merged commit e6b64a6 into celestiaorg:main Oct 31, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI tests for Ledger support
5 participants