Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary abs operation from power diff #2798

Merged
merged 1 commit into from
Nov 1, 2023
Merged

chore: remove unnecessary abs operation from power diff #2798

merged 1 commit into from
Nov 1, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Nov 1, 2023 •
edited
Loading

Overview

Closes #2800

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id requested a review from evan-forbes as a code owner November 1, 2023 10:08
@rach-id rach-id marked this pull request as draft November 1, 2023 10:08
@celestia-bot celestia-bot requested review from a team and mojtaba-esk and removed request for a team November 1, 2023 10:09
@rach-id rach-id self-assigned this Nov 1, 2023
@rach-id rach-id added the x/blobstream item is directly relevant to the blob module label Nov 1, 2023
@rach-id rach-id marked this pull request as ready for review November 1, 2023 10:25
@rach-id rach-id merged commit abe06e3 into celestiaorg:main Nov 1, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@rootulp rootulp rootulp approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

@mojtaba-esk mojtaba-esk Awaiting requested review from mojtaba-esk mojtaba-esk is a code owner automatically assigned from celestiaorg/celestia-core

Assignees

@rach-id rach-id

Labels
x/blobstream item is directly relevant to the blob module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary Abs operation in power diff calculation
3 participants
@rach-id @rootulp @cmwaters