Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mempool overrides #2823

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 8, 2023

I wanted to see what value we use for MaxTxsBytes. Since it's computed and not hard-coded, I wrote a test to see it and verify we don't accidentally revert it.

@rootulp rootulp self-assigned this Nov 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2823 (bab2c92) into main (7e9fb84) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2823      +/-   ##
==========================================
+ Coverage   19.44%   19.59%   +0.15%     
==========================================
  Files         143      143              
  Lines       17320    17320              
==========================================
+ Hits         3368     3394      +26     
+ Misses      13633    13607      -26     
  Partials      319      319              

see 1 file with indirect coverage changes

@rootulp rootulp marked this pull request as ready for review November 8, 2023 12:45
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do these kind of compatibility vector tests in many other cases as well to prevent us from accidentally breaking stuff

@rootulp rootulp merged commit b02fe3a into celestiaorg:main Nov 8, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants