feat(cmd): snapshots command #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2825 +/- ##
==========================================
- Coverage 19.44% 19.44% -0.01%
==========================================
Files 143 143
Lines 17320 17323 +3
==========================================
Hits 3368 3368
- Misses 13633 13636 +3
Partials 319 319
|
cmwaters
approved these changes
Nov 8, 2023
Comment on lines
+153
to
+155
| rootCmd.AddCommand( | ||
| snapshot.Cmd(NewAppServer), | ||
| ) |
There was a problem hiding this comment.
nit: I guess this could have just been appended to the AddCommand function above
There was a problem hiding this comment.
true. TBH the contents of this function don't make sense to me. IDK why we add some commands in a block at the top and then add more later
There was a problem hiding this comment.
yeah it's all a bit messy but not too problematic
rootulp
added
the
backport:v1.x
evan-forbes
approved these changes
Nov 8, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
Closes #2824 ## Testing I verified the snapshots command was added ```shell $ ./build/celestia-appd snapshots Manage local snapshots Usage: celestia-appd snapshots [command] Available Commands: delete Delete a local snapshot dump Dump the snapshot as portable archive format export Export app state to snapshot store list List local snapshots load Load a snapshot archive file (.tar.gz) into snapshot store restore Restore app state from local snapshot Flags: -h, --help help for snapshots ``` (cherry picked from commit 7d28fc0)
rootulp
added a commit
that referenced
this pull request
Nov 8, 2023
This is an automatic backport of pull request #2825 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Rootul P <[email protected]>
cmwaters
pushed a commit
that referenced
this pull request
Nov 9, 2023
Closes #2824 ## Testing I verified the snapshots command was added ```shell $ ./build/celestia-appd snapshots Manage local snapshots Usage: celestia-appd snapshots [command] Available Commands: delete Delete a local snapshot dump Dump the snapshot as portable archive format export Export app state to snapshot store list List local snapshots load Load a snapshot archive file (.tar.gz) into snapshot store restore Restore app state from local snapshot Flags: -h, --help help for snapshots ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2824
Testing
I verified the snapshots command was added