fix: handle context cancellations in txsim (backport #2830) #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
I have seen a few CI tests fail because although the context stops the process, it isn't correctly parsed causing the program that called the txsim to think that there was another error and not the context Canceled or DeadlineExceeded errors (cherry picked from commit 5dfe777)
mergify
bot
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
Codecov Report
@@ Coverage Diff @@
## v1.x #2833 +/- ##
=======================================
Coverage 20.20% 20.20%
=======================================
Files 139 139
Lines 16237 16237
=======================================
Hits 3280 3280
Misses 12649 12649
Partials 308 308
|
cmwaters
approved these changes
Nov 10, 2023
rootulp
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2830 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com