Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lower the default mempool min gas price #2843

Merged
merged 3 commits into from
Nov 20, 2023
+2 −2
Merged

chore: lower the default mempool min gas price #2843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c408e3
chore: lower the default mempool min gas price
evan-forbes Nov 14, 2023
eec84a1
chore: fix hardcoded test
evan-forbes Nov 14, 2023
6933d28
chore: lower the fee further to .002utia
evan-forbes Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/default_overrides_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func TestDefaultAppConfig(t *testing.T) {

assert.Equal(t, uint64(1500), cfg.StateSync.SnapshotInterval)
assert.Equal(t, uint32(2), cfg.StateSync.SnapshotKeepRecent)
assert.Equal(t, "0.1utia", cfg.MinGasPrices)
assert.Equal(t, "0.002utia", cfg.MinGasPrices)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] how was .002utia arrived at? IIUC 0.1utia was arrived at based on rough estimates. How did the estimates change to go from 0.1 -> 0.01 -> 0.002?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the original value was off by two orders of magnitude, I would expect 0.1 -> 0.01 -> 0.001

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cosmos/chain-registry/blob/957a4c779024535ea947e13db6b2d101305fcadd/celestia/chain.json#L21 I'll keep an eye on thei thread and match what the consensus here is, in chain-registry

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since .002utia got merged here, I think we may want to update chain-registry to

        "low_gas_price": 0.002,
        "average_gas_price": 0.004,
        "high_gas_price": 0.008

but we likely only want to do this after a decent chunk of validators have updated to a release that includes this. On second thought, I think their locally configured default won't get overridden with this new default so our release notes should probably explicitly call out the manual action that validators need to take.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmos/chain-registry#3239
chainapsis/keplr-chain-registry#290

updating these now, but leaving in draft

}

func TestDefaultConsensusConfig(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/appconsts/initial_consts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const (
// DefaultMinGasPrice is the default min gas price that gets set in the app.toml file.
// The min gas price acts as a filter. Transactions below that limit will not pass
// a nodes `CheckTx` and thus not be proposed by that node.
DefaultMinGasPrice = 0.1
DefaultMinGasPrice = 0.002

// DefaultUnbondingTime is the default time a validator must wait
// to unbond in a proof of stake system. Any validator within this
Expand Down