Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove import hack for protobuf any #2846

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 15, 2023

Closes #744

This import hack doesn't seem necessary b/c it doesn't actually modify x/blobstream/types/query.pb.go

Testing

$ rm x/blobstream/types/query.pb.go
$ make proto-gen

and then observe that there is no git diff so no changes to the already checked in x/blobstream/types/query.pb.go and the generated one.

Also proto-gen passes in CI: https://github.com/celestiaorg/celestia-app/actions/runs/6881660922/job/18718509598?pr=2846

@rootulp rootulp requested a review from rach-id November 15, 2023 18:54
@rootulp rootulp self-assigned this Nov 15, 2023
@rootulp rootulp marked this pull request as ready for review November 15, 2023 18:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b75c7e3) 19.16% compared to head (7ab1759) 19.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2846   +/-   ##
=======================================
  Coverage   19.16%   19.16%           
=======================================
  Files         142      142           
  Lines       17291    17291           
=======================================
  Hits         3313     3313           
  Misses      13676    13676           
  Partials      302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the testing process (after removing the replacement command in the bash script); I can also confirm that the import path of the types package points to the cosmos types package i.e.,github.com/cosmos/cosmos-sdk/codec/types. This renders the import hack unnecessary and safe to remove.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we can remove this as the protobuf is no longer changing, but I'm curious as to what changed that fixed this. Was it the update to gogo proto?

will defer @sweexordious for final approval to be abundantly cautious and for additional context

@rootulp rootulp removed the request for review from cmwaters November 16, 2023 14:55
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, tested it and it's not needed anymore 🎉

@rootulp rootulp enabled auto-merge (squash) November 16, 2023 18:13
@rootulp rootulp merged commit 9b5d025 into celestiaorg:main Nov 16, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove temporary import hack for protobuf any
5 participants