-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove import hack for protobuf any #2846
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2846 +/- ##
=======================================
Coverage 19.16% 19.16%
=======================================
Files 142 142
Lines 17291 17291
=======================================
Hits 3313 3313
Misses 13676 13676
Partials 302 302 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the testing process (after removing the replacement command in the bash script); I can also confirm that the import path of the types
package points to the cosmos types package i.e.,github.com/cosmos/cosmos-sdk/codec/types
. This renders the import hack unnecessary and safe to remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like we can remove this as the protobuf is no longer changing, but I'm curious as to what changed that fixed this. Was it the update to gogo proto?
will defer @sweexordious for final approval to be abundantly cautious and for additional context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, tested it and it's not needed anymore 🎉
Closes #744
This import hack doesn't seem necessary b/c it doesn't actually modify
x/blobstream/types/query.pb.go
Testing
and then observe that there is no
git diff
so no changes to the already checked inx/blobstream/types/query.pb.go
and the generated one.Also proto-gen passes in CI: https://github.com/celestiaorg/celestia-app/actions/runs/6881660922/job/18718509598?pr=2846