Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: configure prerelease-suffix #2898

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Dec 4, 2023

@rootulp rootulp added the backport:v1.x PR will be backported automatically to the v1.x branch upon merging label Dec 4, 2023
@rootulp rootulp self-assigned this Dec 4, 2023
Copy link
Contributor

coderabbitai bot commented Dec 4, 2023

Walkthrough

Walkthrough

The change introduces a new prerelease_suffix configuration option in the .goreleaser.yaml file, which is likely intended to modify the behavior of the GoReleaser tool during the release process, particularly in handling prerelease versions.

Changes

File Change Summary
.goreleaser.yaml Added prerelease_suffix configuration option to git section

Assessment against linked issues

Objective Addressed Explanation
#2897: Ensure GoReleaser correctly attaches prebuilt binaries to releases The change suggests an adjustment in the release process, possibly to address the issue with tagging. However, without the context of how prerelease_suffix is used by GoReleaser, it's unclear if this directly resolves the problem of attaching binaries to the correct tag.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@rootulp rootulp requested review from staheri14 and rach-id December 4, 2023 20:34
@celestia-bot celestia-bot requested a review from a team December 4, 2023 20:34
@rootulp rootulp enabled auto-merge (squash) December 4, 2023 21:05
@rootulp rootulp merged commit 4e966f9 into celestiaorg:main Dec 4, 2023
31 checks passed
mergify bot pushed a commit that referenced this pull request Dec 4, 2023
rootulp added a commit that referenced this pull request Dec 4, 2023
This is an automatic backport of pull request #2898 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: Rootul P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoReleaser failed to attach prebuilt binaries to v1.5.0
3 participants