Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix all typos on the repository #2926

Merged
merged 6 commits into from
Dec 12, 2023
Merged

chore: fix all typos on the repository #2926

merged 6 commits into from
Dec 12, 2023

Conversation

hoangdv2429
Copy link
Contributor

This PR will fix typos that exist on current repository
(variable name will stay untouch)

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords
  • I reviewed file changes myself.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2023 •
edited
Loading

Walkthrough

Walkthrough

The changes across the codebase are predominantly minor text corrections in comments, documentation, and error messages. These include spelling fixes, grammar improvements, and clarification of existing comments. A notable change is the renaming of a method in pkg/user/signer.go from GetSequencer to GetSequence. There are also some clarifications and enhancements in architectural decision records (ADRs) and test scripts. No changes significantly alter the logic or control flow of the code.

Changes

File(s) Summary of Change
.gitignore, app/ante/ante.go, app/process_proposal.go, app/test/fuzz_abci_test.go,
pkg/appconsts/global_consts.go, pkg/user/signer.go, x/mint/types/constants.go		 Minor text corrections in comments, documentation, and error messages.
docs/architecture/adr-006-non-interactive-defaults.md Introduced parsedTx data structure for managing malleated transactions.
docs/architecture/adr-014-versioned-namespaces.md Clarified namespace versioning and its implications for data layout.
docs/architecture/adr-020-deterministic-square-construction.md Simplified square construction to a deterministic function and added its counterpart.
pkg/appconsts/global_consts.go Fixed typos in comments.
pkg/user/signer.go Renamed method from GetSequencer to GetSequence.
x/mint/types/constants.go Corrected spelling in a constant declaration comment.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment from CodeRabbit.
  • You can also chat with CodeRabbit bot directly around the specific lines of code or files in the PR by tagging @coderabbitai in a new comment.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@celestia-bot celestia-bot requested a review from a team December 12, 2023 15:41
hoangdv2429
hoangdv2429 commented Dec 12, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@hoangdv2429 hoangdv2429 changed the title Chore: fix all typos on the repository chore: fix all typos on the repository Dec 12, 2023
@hoangdv2429
Copy link
Contributor Author

@rootulp Hi sir, can you review this one ?

coderabbitai[bot]
coderabbitai bot reviewed Dec 12, 2023
View reviewed changes
pkg/user/signer.go Outdated Show resolved Hide resolved
hoangdv2429 and others added 3 commits December 12, 2023 22:52
@hoangdv2429 @coderabbitai
Update pkg/user/signer.go
3dd60f5 
wow, this is cool

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@hoangdv2429
revert
5709858
@hoangdv2429
Merge branch 'chore/fix_all_typo' of https://github.com/hoangdv2429/c…
76552b0 
…elestia-app into chore/fix_all_typo
rootulp
rootulp approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @hoangdv2429 !

test/testground/manifest.toml
@@ -38,7 +38,7 @@ blobs_per_sequence = { type = "int", default = 1 }
inbound_peer_count = { type = "int", default = 40 }
outbound_peer_count = { type = "int", default = 10 }
gov_max_square_size = { type = "int", default = 256 }
max_block_bytes = { type = "int", deafult = 100000000 }
max_block_bytes = { type = "int", default = 100000000 }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow I'm surprised the previous incorrect spelling didn't result in broken behavior

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised too, maybe max_block_bytes is not being test.. ?

@rootulp rootulp merged commit 098bcb4 into celestiaorg:main Dec 12, 2023
31 checks passed
@BorkBorked BorkBorked mentioned this pull request Dec 12, 2023
Merged
rootulp pushed a commit that referenced this pull request Dec 13, 2023
@BorkBorked
chore(pkg/user): fix typo (#2929)
e0edb4c 
very last forgotten typo from #2926 

the repo should now be typo free, quite the feat!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@rootulp rootulp rootulp approved these changes

@rach-id rach-id Awaiting requested review from rach-id

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

@liamsi liamsi Awaiting requested review from liamsi

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@hoangdv2429 hoangdv2429

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoangdv2429 @rootulp