Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testground): updates the app version in testground test #2951

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

staheri14
Copy link
Collaborator

Closes #2948
For rationale of this change please refer to this comment.

@staheri14 staheri14 self-assigned this Dec 19, 2023
@staheri14 staheri14 added the fix label Dec 19, 2023
@staheri14 staheri14 marked this pull request as ready for review December 19, 2023 18:51
@@ -3,7 +3,7 @@ module github.com/celestiaorg/celestia-app/test/testground
go 1.21.1

require (
github.com/celestiaorg/celestia-app v1.0.0-rc0.0.20231120210508-c4a02614e8bc
github.com/celestiaorg/celestia-app v1.0.0-rc0.0.20231219172024-f57f5c104ea0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the fix was to upgrade to a more recent version of celestia-app. A.k.a this commit: f57f5c1

Copy link
Collaborator Author

@staheri14 staheri14 Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is correct [and it does now point to the most recent version of the app]

@staheri14 staheri14 merged commit f20b0a9 into main Dec 19, 2023
31 checks passed
@staheri14 staheri14 deleted the sanaz/update-app-version-testground-gomod branch December 19, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix for AppVersion argument error in Testground execution
2 participants