Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Imporve signer confirm tx #2970

Merged
merged 13 commits into from
Jan 10, 2024
Merged

refactor: Imporve signer confirm tx #2970

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
47eaf93
Imporve signer confirm tx.
htiennv Dec 28, 2023
b91480e
Add mutex for access poolTime.
htiennv Dec 28, 2023
0ee0973
Return resp instead of nil.
htiennv Jan 2, 2024
96b6ec0
Fix tests.
htiennv Jan 6, 2024
4fc9362
Fix typo.
htiennv Jan 6, 2024
299f790
test: run TestConfirmTxTimeout
rootulp Jan 7, 2024
6399277
test: fix TestConfirmTxTimeout
rootulp Jan 7, 2024
2dd6792
test: improve test
rootulp Jan 7, 2024
dab79ff
Revert godoc for ConfirmTx
htiennv Jan 8, 2024
0da89a0
Add some tests for ConfirmTx
htiennv Jan 9, 2024
d06be56
Fix comments.
htiennv Jan 10, 2024
34656e2
Refactor for TestConfirmTx
htiennv Jan 10, 2024
2ac5db5
Fix imported more than once
htiennv Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Return resp instead of nil.
  • Loading branch information
@htiennv
htiennv committed Jan 9, 2024
commit 0ee0973b45ca0e06b4144244a12b235608f83ee3
3 changes: 2 additions & 1 deletion pkg/user/signer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ func (s *Signer) SubmitPayForBlob(ctx context.Context, blobs []*blob.Blob, opts
return nil, err
}
if resp.Code != 0 {
return nil, fmt.Errorf("tx failed with code %d: %s", resp.Code, resp.RawLog)
// TODO(htienv): Should return nil here?
return resp, fmt.Errorf("tx failed with code %d: %s", resp.Code, resp.RawLog)
}

return s.ConfirmTx(ctx, resp.TxHash)
Expand Down