Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/cosmos/cosmos-sdk from 0.40.0-rc5 to 0.41.3 #30

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 19, 2021

Bumps github.com/cosmos/cosmos-sdk from 0.40.0-rc5 to 0.41.3.

Release notes

Sourced from github.com/cosmos/cosmos-sdk's releases.

v0.41.3

Cosmos SDK v0.41.3 "Stargate" Release Notes

This release fixes a build failure caused by a small API breakage introduced in Tendermint v0.34.7. It is highly recommended that all applications using v0.41.2 upgrade to v0.41.3 as soon as possible.

See the Cosmos SDK v0.41.3 milestone on our issue tracker for details.

v0.41.2

Cosmos SDK v0.41.2 "Stargate" Release Notes

This release upgrades Tendermint to v0.34.7, and does not introduce any breaking changes. It is highly recommended that all applications using v0.41.1 upgrade to v0.41.2 as soon as possible.

Tendermint v0.34.7

Operators running nodes that manage their keys through the Tendermint's FilePV implementation were susceptible to leaking private keys material in the logs. The issue is now fixed in Tendermint v0.34.5 and later versions.

For more information regarding the patch, please refer to Tendermint's changelog.

v0.41.1

Cosmos SDK v0.41.1 "Stargate" Release Notes

This release includes two security patches, and does not introduce any breaking changes. It is highly recommended that all applications using v0.41.0 upgrade to v0.41.1 as soon as possible.

See the Cosmos SDK v0.41.1 milestone on our issue tracker for details.

Security Patch #1: All gRPC requests are now routed through ABCI

When Tendermint commits a new block, the versions map in IAVL MutableTree is updated. If, at the same time, a concurrent gRPC request is performed, it will read the same versions map, causing the node to crash.

The patch consists of routing all gRPC requests through ABCI. The Go implementation of ABCI uses global lock on all requests, making them linearizable (received one at a time) which in turn prevents concurrent map reads and writes.

We are exploring on ways of introducing concurrent gRPC queries in #8591.

This bug has been reported via HackerOne.

Security Patch #2: Remove GetValidator cache map

The x/staking keeper holds an internal validatorCache cache map of validators. When multipile gRPC queries are performed simulataneously, concurrent reads and writes of this map can happen, causing the node to crash.

The patch removes the validatorCache altogether. Benchmarks show that the removal of the cache map even increases performance.

Is is important to note that the Security Patch #1 should also fix this bug, as it forces synchronous gRPC queries and therefore synchronous map reads/writes. However, it was deemed useful to include this bugfix too in this release.

Bug Fixes & Improvements

Several bug fixes and non-breaking improvements are included in this release.

Tendermint has been bumped to v0.34.4 to address a memory leak.

... (truncated)

Changelog

Sourced from github.com/cosmos/cosmos-sdk's changelog.

v0.41.3 - 2021-02-18

Bug Fixes

  • #8617 Fix build failures caused by a small API breakage introduced in tendermint v0.34.7.

v0.41.2 - 2021-02-18

Improvements

  • Bump tendermint dependency to v0.34.7.

v0.41.1 - 2021-02-17

Bug Fixes

  • (grpc) #8549 Make gRPC requests go through ABCI and disallow concurrency.
  • (x/staking) #8546 Fix caching bug where concurrent calls to GetValidator could cause a node to crash
  • (server) #8481 Don't create files when running {appd} tendermint show-* subcommands.
  • (client/keys) #8436 Fix keybase->keyring keys migration.
  • (crypto/hd) #8607 Make DerivePrivateKeyForPath error and not panic on trailing slashes.

Improvements

  • (x/ibc) #8458 Add packet_connection attribute to ibc events to enable relayer filtering
  • #8396 Add support for ARM platform
  • (x/bank) #8479 Aditional client denom metadata validation for base and display denoms.
  • (codec/types) #8605 Avoid unnecessary allocations for NewAnyWithCustomTypeURL on error.

v0.41.0 - 2021-01-26

State Machine Breaking

  • (x/ibc) #8266 Add amino JSON for IBC messages in order to support Ledger text signing.
  • (x/ibc) #8404 Reorder IBC ChanOpenAck and ChanOpenConfirm handler execution to perform core handler first, followed by application callbacks.

Bug Fixes

  • (simapp) #8418 Add balance coin to supply when adding a new genesis account
  • (x/bank) #8417 Validate balances and coin denom metadata on genesis
  • (x/staking) #8546 Fix caching bug where concurrent calls to GetValidator could cause a node to crash

v0.40.1 - 2021-01-19

Improvements

  • (x/bank) #8302 Add gRPC and CLI queries for client denomination metadata.
  • (tendermint) Bump Tendermint version to v0.34.3.

Bug Fixes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 19, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 19, 2021

The following labels could not be found: automerge.

@liamsi
Copy link
Member

liamsi commented Feb 20, 2021

This should happen in coordination with celestiaorg/cosmos-sdk#18 and will require manually updating the replace directive.

@liamsi liamsi closed this Feb 20, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 20, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@liamsi liamsi deleted the dependabot/go_modules/github.com/cosmos/cosmos-sdk-0.41.3 branch February 20, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant