-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable pebble #3124
feat: enable pebble #3124
Conversation
Important Auto Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review @coderabbitai & reviewers - to finish off this PR, there's a second PR on the celestia-core repository, here: The celestia-core PR allows celestia-core to use go 1.22 and so it needed to update some pyroscope dependencies. There's also a PR to cometbft-db here: Once the cometbft-db PR is merged, I'll be able to use it without the replace statement in the celestia-core PR, and in this PR, too. |
@faddat, I understand the dependencies between the PRs across the celestia-app, celestia-core, and cometbft-db repositories. While I can't directly check the merge status of external PRs or their specific changes, I can review the changes within the celestia-app PR that are related to the Go 1.22 update and pyroscope dependencies adjustments. Please ensure that any necessary updates or dependency changes in the celestia-app PR are aligned with the updates in the celestia-core and cometbft-db PRs. If there are specific files or configurations within the celestia-app PR that you would like me to focus on, especially those affected by the updates in the other repositories, please let me know. Action performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this @faddat
go 1.21.1 | ||
go 1.22 | ||
|
||
toolchain go1.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we would do this in a separate PR, is this required for the other changes here? if so, then we will likely need to create a different PR that also updates all the CI to use the latest go version
@@ -223,5 +233,6 @@ replace ( | |||
github.com/cosmos/cosmos-sdk => github.com/celestiaorg/cosmos-sdk v1.18.3-sdk-v0.46.14 | |||
github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | |||
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 | |||
github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.32.0-tm-v0.34.29 | |||
github.com/tendermint/tendermint => github.com/faddat/celestia-core v1.29.0-tm-v0.34.29.0.20240221225107-acff1e186d7b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming that this is just blocked by the same PR in core, but we might want to mention that in the draft comment
@@ -223,5 +233,6 @@ replace ( | |||
github.com/cosmos/cosmos-sdk => github.com/celestiaorg/cosmos-sdk v1.18.3-sdk-v0.46.14 | |||
github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | |||
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 | |||
github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.32.0-tm-v0.34.29 | |||
github.com/tendermint/tendermint => github.com/faddat/celestia-core v1.29.0-tm-v0.34.29.0.20240221225107-acff1e186d7b | |||
github.com/tendermint/tm-db => github.com/faddat/tm-db v0.6.6-0.20240221221500-fc0fbd3cc893 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this what are the other consequences of this? could this be upstreamed or is this also blocked by an upstream PR?
Closing b/c this doesn't appear to be actively worked on. Please re-open if I misinterpreted. |
Overview
Checklist