Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to golangci-lint v1.57.0 #3197

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 20, 2024

Closes #3195

idk which golangci-lint release fixed the issue in #3195 but CI passes on this PR 🤷‍♂️

@rootulp rootulp self-assigned this Mar 20, 2024
@rootulp rootulp marked this pull request as ready for review March 20, 2024 14:53
Copy link
Contributor

coderabbitai bot commented Mar 20, 2024

Walkthrough

Walkthrough

The changes primarily focus on updating dependencies, refining function signatures, and enhancing code consistency across various parts of the project. Notably, there's an update to the golangci-lint version to improve linting, adjustments to function parameters to match expected types or remove unused ones, and renaming variables for better readability and uniformity. These modifications aim to streamline the codebase, ensuring it adheres to best practices and remains maintainable.

Changes

Files Summary
.github/workflows/lint.yml, README.md Update golangci-lint version from 1.55.2 to 1.57.0
app/.../migrations_test.go Modify RegisterMigration call in test function
app/.../process_proposal_test.go Update mutator parameter to take a pointer
cmd/celestia-appd/cmd/addrbook.go Modify function signature in addrbookCommand
test/cmd/txsim/cli.go Update RunE function signature
x/blob/ante/ante_test.go Modify parameters in test function
x/blob/client/cli/query_params.go Remove unused args parameter in RunE function
x/blob/types/payforblob.go, x/blob/types/payforblob_test.go Rename variables for consistency
x/blobstream/client/query_test.go Change parameter name from t to _
x/mint/client/cli/query.go Modify RunE function signatures
x/upgrade/cli/tx.go Adjust RunE function signature to ignore args parameter

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Collaborator

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@rootulp rootulp merged commit cee9cd4 into celestiaorg:main Mar 20, 2024
34 checks passed
@rootulp rootulp deleted the rp/fix-golangci-lint branch March 20, 2024 16:03
ninabarbakadze pushed a commit to ninabarbakadze/celestia-app that referenced this pull request Apr 2, 2024
Closes celestiaorg#3195

idk which golangci-lint release fixed the issue in
celestiaorg#3195 but CI passes on
this PR 🤷‍♂️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: ci-release workflow fails at the golangci-lint job
3 participants