Generate a MsgWirePayForMessage via CLI
#32
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| package cli | ||
|
|
||
| import ( | ||
| "encoding/hex" | ||
| "errors" | ||
|
|
||
| "github.com/cosmos/cosmos-sdk/client" | ||
| "github.com/cosmos/cosmos-sdk/client/flags" | ||
| "github.com/cosmos/cosmos-sdk/client/tx" | ||
| "github.com/lazyledger/lazyledger-app/x/lazyledgerapp/types" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| // CmdCreatePayForMessage returns a cobra command that uses the key ring backend | ||
| // and locally running node to create and broadcast a new WirePayForMessage | ||
| // transaction. | ||
| func CmdCreatePayForMessage() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "payForMessage [hexNamespace] [hexMessage]", | ||
| Short: "Creates a new WirePayForMessage", | ||
| Args: cobra.ExactArgs(2), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| clientCtx, err := client.GetClientTxContext(cmd) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // get the account name | ||
| accName := clientCtx.GetFromName() | ||
| if accName == "" { | ||
| return errors.New("no account name provided, please use the --from flag") | ||
| } | ||
|
|
||
| // get info on the key | ||
| keyInfo, err := clientCtx.Keyring.Key(accName) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // decode the namespace | ||
| namespace, err := hex.DecodeString(args[0]) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // decode the message | ||
| message, err := hex.DecodeString(args[1]) | ||
| if err != nil { | ||
| return err | ||
|
There was a problem hiding this comment. For better UX, maybe you can wrap error and provide info what argument (namespace or message) is wrong? There was a problem hiding this comment. nice catch! You just saved someone some time 🙂 not all heroes wear capes 😉 resolved db5a91c |
||
| } | ||
|
|
||
| // create the PayForMessage | ||
| pfmMsg, err := types.NewMsgWirePayForMessage( | ||
| namespace, | ||
| message, | ||
| keyInfo.GetPubKey().Bytes(), | ||
| &types.TransactionFee{}, // transaction fee is not yet used | ||
| types.SquareSize, | ||
| ) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // sign the PayForMessage's ShareCommitments | ||
| err = pfmMsg.SignShareCommitments(accName, clientCtx.Keyring) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // run message checks | ||
| if err = pfmMsg.ValidateBasic(); err != nil { | ||
| return err | ||
| } | ||
| return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), pfmMsg) | ||
| }, | ||
| } | ||
|
|
||
| flags.AddTxFlagsToCmd(cmd) | ||
|
|
||
| return cmd | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,27 @@ | ||
| package keeper | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/lazyledger/lazyledger-app/x/lazyledgerapp/types" | ||
| ) | ||
|
|
||
| var _ types.MsgServer = msgServer{} | ||
|
|
||
| // MsgServer is the server API for Msg service. | ||
| type MsgServer interface { | ||
| // PayForMessage allows the user to post data to made be available. | ||
| PayForMessage(context.Context, *types.MsgWirePayForMessage) (*types.MsgPayForMessageResponse, error) | ||
| // PayForMessage allows the user to post data to made be available. | ||
| SignedTransactionDataPayForMessage(context.Context, *types.SignedTransactionDataPayForMessage) (*types.SignedTransactionDataPayForMessageResponse, error) | ||
| } | ||
|
|
||
|
Comment on lines
+11
to
+18
There was a problem hiding this comment. What is the relation of this interface to the There was a problem hiding this comment. The There was a problem hiding this comment. What was the reason again to only have one endpoint here? There was a problem hiding this comment. because each |
||
| type msgServer struct { | ||
| Keeper | ||
| } | ||
|
|
||
| // NewMsgServerImpl returns an implementation of the bank MsgServer interface | ||
| // for the provided Keeper. | ||
| func NewMsgServerImpl(keeper Keeper) MsgServer { | ||
| return &msgServer{Keeper: keeper} | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other Tx are in JSON encoding or hex, too? (I mean on the cli)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good question. I'm not sure. In other tx, each argument is parsed individually, and the only ones handling raw bytes are using either amino or the Bech32 address encoding. For example
lazyledger-appd tx decode [amino-byte-string] [flags]uses the amino byte string, and all addresses are inputted as a Bech32 string. Should it use amino? Something else to handle bytes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOOOOOOO! please don't :-D
But seriously, let's go with hex bytes for now. Let's open an issue about the UX/UI of the CLI. I'm also not sure what would be best here. We can address this much later anyway (before mainnet). Probably the main usage won't be over the CLI but from other chains too.
And I find
payForMessage [hexNamespace] [hexMessage]clear and simple enough.