Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minor naming changes and updates in specs #3204

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

ninabarbakadze
Copy link
Member

Overview

follow-up pr addressing some of the comments on minfee-module

Copy link
Contributor

coderabbitai bot commented Mar 21, 2024

Warning

Rate Limit Exceeded

@ninabarbakadze has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 2 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between f1b85f4 and 74e30ed.

Walkthrough

The changes enhance transaction fee validation by aligning with node-specific thresholds and introducing a global minimum gas price policy. The new minfee module empowers governance-driven adjustments to network economics.

Changes

File(s) Summary
app/ante/ante.go, app/ante/fee_checker.go Updated fee logic to use ValidateTxFeeWrapper, renamed CheckTxFeeWithMinGasPrices to ValidateTxFee.
app/ante/min_fee_test.go Test updated to use ValidateTxFee instead of CheckTxFeeWithMinGasPrices.
go.work.sum Added v0.110.8 for cloud.google.com/go, cloud.google.com/go/compute, updated github.com/ferranbt/fastssz to v0.1.2, and made various version updates under golang.org/x/. Removed github.com/felixge/httpsnoop.
specs/src/specs/params.md Introduced minfee.GlobalMinGasPrice, removed mint.GlobalMinGasPrice, and clarified governance restrictions on mint module parameters.
specs/src/specs/state_machine_modules.md, x/minfee/README.md Added minfee module for managing network-wide minimum gas prices via governance proposals.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@celestia-bot celestia-bot requested a review from a team March 21, 2024 14:35
Copy link
Member Author

@ninabarbakadze ninabarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdown-linter throws error because minfee/readme.md link doesn't exist yet but it will after this pr is merged.

@@ -10,6 +10,7 @@ Celestia app is built using the cosmos-sdk, and follows standard cosmos-sdk modu
- [paramfilter](https://github.com/celestiaorg/celestia-app/blob/main/x/paramfilter/README.md)
- [upgrade](https://github.com/celestiaorg/celestia-app/blob/main/x/upgrade/README.md)
- [tokenfilter](https://github.com/celestiaorg/celestia-app/blob/main/x/tokenfilter/README.md)
- [minfee](https://github.com/celestiaorg/celestia-app/blob/main/x/minfee/README.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 please alphabetize

x/minfee/README.md Outdated Show resolved Hide resolved
x/minfee/README.md Outdated Show resolved Hide resolved
ninabarbakadze and others added 2 commits March 21, 2024 17:16
@celestia-bot celestia-bot requested a review from a team March 21, 2024 16:16
@ninabarbakadze ninabarbakadze merged commit d5a9362 into celestiaorg:main Mar 21, 2024
33 of 34 checks passed
@ninabarbakadze ninabarbakadze deleted the nina/minfee-followup branch March 21, 2024 22:27
ninabarbakadze added a commit to ninabarbakadze/celestia-app that referenced this pull request Apr 2, 2024
## Overview

follow-up pr addressing some of the comments on
[minfee-module](celestiaorg#3094)

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants