Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adds the ability to run txsim as knuu instance for testground sanity test #3244

Merged
merged 71 commits into from
Apr 5, 2024
Merged

test: adds the ability to run txsim as knuu instance for testground sanity test #3244

merged 71 commits into from
Apr 5, 2024

Conversation

staheri14
Copy link
Collaborator

@staheri14 staheri14 commented Apr 2, 2024 •
edited
Loading

Closes #3189

Summary of changes:

  • Introduces the capability to customize the resource allocation for each Node and TxSimNode individually
  • Enables running txsim as a knuu instance.
  • Allows spinning up multiple instances of txsim (e.g., one or more per validator)
  • Enhanced logs

I have also tested all the e2e tests, and they pass successfully.

staheri14 and others added 30 commits March 26, 2024 13:19
@staheri14
the same sanity test with the older version of main and txsim
f83f6f5
@staheri14
increase bw to 500MiB/s
d6007d3
@staheri14
removes the redundant waiting for the instance being running
34aef77
@staheri14
reduces the seq count to 1
e55201c
@staheri14
adds go sums
30fc16b
@staheri14
adds the ability to pass rpc endpoint
a62ad72
@staheri14
increases timeout commit and propose
5e77f11
@staheri14
increase bw and timeoutcommit
7f0adc1
@staheri14
uses testground app version
1cfafc6
@staheri14
creates up to 5 blobs per txsim PFB
e6ad88e
@staheri14
imports testground package
47649b3
@staheri14
increases resources per validator and returns block times in nanoseconds
6249066
@staheri14
increases gov max square size
2b5a038
@staheri14
Merge remote-tracking branch 'origin/main' into sanaz/old-version-san…
6030f51 
…ity-test
@staheri14
points to the latest txsim
9af08d3
@cmwaters
fix genesis account creation in e2e tests
dc929b9
@staheri14
Merge branch 'main' into sanaz/old-version-sanity-test
3192104
@staheri14
Merge branch 'cal/genesis-account-e2e' into sanaz/old-version-sanity-…
e8c1812 
…test
@staheri14
comments out testground version
242f4ee
@staheri14
deletes unused comments and introduces max resources var
6a1d9d6
@staheri14
adds some defaults for max resources for each instance type
2441b83
@staheri14
removes plotting utils
e6527c0
@staheri14
adds txsim account to the genesis
e6b1d39
@staheri14
removes plot dependencies
ce95b43
@staheri14
brings back default app version to the latest
f793a56
@staheri14
deletes plots
53871ec
@staheri14
reverts updates on the DefaultGovMaxSquareSize value
96f7af0
@staheri14
resets the configs
3a1cf52
@staheri14
cleans up comments
443221d
@staheri14
deletes rpc endpoint assignment for txsims
898f5a3
coderabbitai[bot]
coderabbitai bot reviewed Apr 4, 2024
View reviewed changes
@staheri14 staheri14 requested review from cmwaters and rootulp April 5, 2024 01:03
coderabbitai[bot]
coderabbitai bot reviewed Apr 5, 2024
View reviewed changes
@staheri14
Copy link
Collaborator Author

The go vulnerabilities should be resolved after bumping go version to Go 1.22.2 i.e., #3263

coderabbitai[bot]
coderabbitai bot reviewed Apr 5, 2024
View reviewed changes
cmwaters
cmwaters previously approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rootulp
rootulp reviewed Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM with one blocking comment

@celestia-bot celestia-bot requested a review from a team April 5, 2024 15:32
@staheri14
Revert "go mod update"
d331fe4 
This reverts commit 391bf08.
@staheri14
Copy link
Collaborator Author

@coderabbitai pause

@staheri14 staheri14 requested review from rootulp and cmwaters April 5, 2024 15:51
@staheri14 staheri14 enabled auto-merge (squash) April 5, 2024 16:44
@celestia-bot celestia-bot requested a review from a team April 5, 2024 18:26
evan-forbes
evan-forbes approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@staheri14 staheri14 merged commit defff08 into main Apr 5, 2024
33 checks passed
@staheri14 staheri14 deleted the sanaz/testground-sanity-test branch April 5, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@rootulp rootulp rootulp approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@ninabarbakadze ninabarbakadze Awaiting requested review from ninabarbakadze

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@staheri14 staheri14

Labels
testing items that are strictly related to adding or extending test coverage WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running txsim as a knuu instance inside e2e tests
4 participants
@staheri14 @rootulp @cmwaters @evan-forbes