Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adds documentation to proofs package #3245
docs: adds documentation to proofs package #3245
Changes from 35 commits
85995ce
70773d3
c440d0a
620862f
7c724dd
ac9d26d
89503a4
5f229cb
1ed2b10
a794155
c15ab0c
20ee12a
78f48e7
841580d
0658aad
da8bc6b
1617d61
8576bb2
f454b83
90f5880
3a22d37
3bcece8
3f0a2eb
0ca3dd2
2deadb7
02e21e3
ddad6a5
433789e
8496a34
c71ee77
183f04e
69863f9
10a87cc
c07f5fa
67f97ce
4642e7e
75c9054
f084fe4
b8a5c0e
b76698c
74c1cc3
8891754
a38a4ed
9b58805
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question] why are there random newlines in the text? Can you please remove the newlines so it's easier to read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's applying structural wrapping. I've seen the convention in the team to use structural wrapping in the docs and everywhere, and goland provides automatic structural wrapping. I am a fan of long lines btw :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is structural wrapping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a feature that automatically formats texts based on it structure, for example it adds a new line after
,
or.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we disable that feature, it makes this content difficult to read. Also why did it add a newline after "means" here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH idk if there's much value to including a link to the consensus specs here but nbd to keep. Can we be more granular and say where in Celestia consensus they're used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to have it necessarily here, but wanted to emphasize the fact that even if this is not exposed, we're respecting all these rules in the consensus