Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(txsim): removes deprecated -r flag from txsim docker README #3325

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

staheri14
Copy link
Collaborator

This PR updates the example txsim Docker command by removing the deprecated -r flag, which was previously used to specify the RPC endpoint.

@staheri14 staheri14 requested a review from a team as a code owner April 15, 2024 22:02
@staheri14 staheri14 requested review from cmwaters and rach-id and removed request for a team April 15, 2024 22:02
@staheri14 staheri14 self-assigned this Apr 15, 2024
Copy link
Contributor

coderabbitai bot commented Apr 15, 2024

Walkthrough

The modification involves simplifying the Docker command used for running the txsim image. A specific flag related to consensus validators was removed, streamlining the command by reducing unnecessary parameters. This change enhances usability and reduces complexity for users.

Changes

File Path Change Summary
docker/README.md Removed a flag related to consensus validators in Docker command, simplifying usage.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@celestia-bot celestia-bot requested a review from a team April 15, 2024 22:02
@staheri14 staheri14 added backport:v1.x PR will be backported automatically to the v1.x branch upon merging chore optional label for items that follow the `chore` conventional commit labels Apr 15, 2024
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@celestia-bot celestia-bot requested review from a team and evan-forbes and removed request for a team April 16, 2024 16:09
@staheri14 staheri14 enabled auto-merge (squash) April 16, 2024 16:09
@staheri14 staheri14 merged commit d60eef7 into main Apr 16, 2024
33 checks passed
@staheri14 staheri14 deleted the sanaz/remove-rpc-input-from-txsim-docker-flags branch April 16, 2024 16:18
mergify bot pushed a commit that referenced this pull request Apr 16, 2024
…3325)

This PR updates the example txsim Docker command by removing the
deprecated `-r ` flag, which was previously used to specify the RPC
endpoint.

(cherry picked from commit d60eef7)

# Conflicts:
#	docker/README.md
ninabarbakadze pushed a commit to ninabarbakadze/celestia-app that referenced this pull request Apr 17, 2024
…elestiaorg#3325)

This PR updates the example txsim Docker command by removing the
deprecated `-r ` flag, which was previously used to specify the RPC
endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants