Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(txsim): enhances logging for debugging failed transactions #3428

Merged
merged 4 commits into from
May 3, 2024

Conversation

staheri14
Copy link
Collaborator

@staheri14 staheri14 commented May 2, 2024

While debugging e2e benchmark tests, I identified an issue with failing PFB transactions submitted by txsim (not a bug in txsim though). To facilitate deeper investigation on the receiver side of the tx, I have added more detailed information about the blob counts and the total size of each failed transaction in this PR. This includes enhancements to the logs for both submitted and failed transactions.

Here is the sample log from txsim after this change:

{"level":"info","height":4,"address":"celestia1jxvmfseuyej7sfclx5n29esj2whjdu99cgh5wu","blobs count":"6","total size of blobs":1200000,"time":"2024-05-02T09:09:33-07:00","message":"tx committed"}
{"level":"info","height":5,"address":"celestia1plxf88u9nc6watyl4zdh77a7k72p8mnudzmyat","blobs count":"6","total size of blobs":1200000,"time":"2024-05-02T09:09:42-07:00","message":"tx committed"}
^C{"level":"error","error":"context canceled","address":"celestia1tt2807wyl82pphfvsefjazrg87r4cqzsdgnfzj","blobs count":"6","total size of blobs":1200000,"time":"2024-05-02T09:09:50-07:00","message":"tx failed"}
{"level":"error","error":"context canceled","address":"celestia1plxf88u9nc6watyl4zdh77a7k72p8mnudzmyat","blobs count":"6","total size of blobs":1200000,"time":"2024-05-02T09:09:50-07:00","message":"tx failed"}
{"level":"error","error":"context canceled","address":"celestia1v4gex6ma7zn7l8s7emturxkpzsy6w3ww57srqv","blobs count":"6","total size of blobs":1200000,"time":"2024-05-02T09:09:50-07:00","message":"tx failed"}
{"level":"error","error":"context canceled","address":"celestia1zuukjreh49zyaetadpga7mq0e0k38p85dvczdd","blobs count":"6","total size of blobs":1200000,"time":"2024-05-02T09:09:50-07:00","message":"tx failed"}
{"level":"error","error":"context canceled","address":"celestia103ye2dumwssgfma24ztq3jq2wzn8mfcaezpzmk","blobs count":"6","total size of blobs":1200000,"time":"2024-05-02T09:09:50-07:00","message":"tx failed"}
{"level":"error","error":"context canceled","address":"celestia1jxvmfseuyej7sfclx5n29esj2whjdu99cgh5wu","blobs count":"6","total size of blobs":1200000,"time":"2024-05-02T09:09:50-07:00","message":"tx failed"}

@staheri14 staheri14 self-assigned this May 2, 2024
@staheri14 staheri14 added WS: Big Blonks 🔭 Improving consensus critical gossiping protocols chore optional label for items that follow the `chore` conventional commit labels May 2, 2024
@staheri14 staheri14 changed the title chore (txsim): enhances logging for debugging failed transactions chore(txsim): enhances logging for debugging failed transactions May 2, 2024
@staheri14 staheri14 marked this pull request as ready for review May 2, 2024 16:50
@staheri14 staheri14 requested a review from a team as a code owner May 2, 2024 16:50
@staheri14 staheri14 requested review from rach-id and ninabarbakadze and removed request for a team May 2, 2024 16:50
Copy link
Contributor

coderabbitai bot commented May 2, 2024

Walkthrough

The update introduces a new function for calculating the byte size of blobs in account.go, enhances logging for both failed and committed transactions, providing more detailed information on transaction specifics.

Changes

File Path Change Summary
test/txsim/account.go Introduced a new function getSize for blob size calculation; updated logging for transaction states.

Possibly related issues


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@staheri14 staheri14 requested a review from rootulp May 2, 2024 16:50
@staheri14 staheri14 enabled auto-merge (squash) May 2, 2024 19:19
@celestia-bot celestia-bot requested a review from a team May 2, 2024 20:37
@staheri14 staheri14 merged commit 234ed83 into main May 3, 2024
33 checks passed
@staheri14 staheri14 deleted the sanaz/logs-for-blob-sizes branch May 3, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants