Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update global min gas price to new value #3444

Merged
merged 5 commits into from
May 9, 2024

Conversation

ninabarbakadze
Copy link
Member

Overview

updates to the new agreed upon value

@ninabarbakadze ninabarbakadze marked this pull request as ready for review May 8, 2024 12:00
@ninabarbakadze ninabarbakadze requested review from liamsi and a team as code owners May 8, 2024 12:00
@ninabarbakadze ninabarbakadze requested review from cmwaters and rach-id and removed request for a team May 8, 2024 12:00
Copy link
Contributor

coderabbitai bot commented May 8, 2024

Walkthrough

The overarching modification across multiple files involves significantly lowering the GlobalMinGasPrice from 0.002 to 0.000001, affecting various components of the Celestia application, including configuration files and code that handles transaction fees.

Changes

File Path Change Summary
local_devnet/celestia-app/genesis.json, .../appconsts/v2/app_consts.go, specs/src/specs/params.md, test/interchain/chainspec/celestia.go All these files reflect a change in the GlobalMinGasPrice from 0.002 to 0.000001.
x/minfee/params.go Updated the import path for appconsts and modified the initialization of DefaultGlobalMinGasPriceDec to use the new gas price value.

Possibly related issues

  • Issue Consider a global minimum gas price #1621: This issue discusses setting a lower bound for transaction gas prices and implementing a global minimum gas price, which directly aligns with the changes made in this PR to adjust the GlobalMinGasPrice.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@celestia-bot celestia-bot requested a review from a team May 8, 2024 15:02
@rootulp rootulp merged commit 068aac6 into celestiaorg:main May 9, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants