test: extend minor version compat to test v2

[rootulp]

Closes #3298

Testing

Relevant logs

$ make test-e2e MinorVersionCompatibility

test-e2e2024/05/09 15:47:37 Running minor version compatibility test versions v1.0.0	v1.1.0	v1.2.0	v1.3.0	v1.4.0	v1.5.0	v1.6.0	v1.7.0	v1.8.0	v1.9.0	v2.0.0-rc0

test-e2e2024/05/09 15:49:38 Starting testnet
test-e2e2024/05/09 15:50:53 Upgrading node node 2 version v1.0.0
test-e2e2024/05/09 15:51:16 Upgrading node node 3 version v1.2.0
test-e2e2024/05/09 15:51:34 Upgrading node node 4 version v2.0.0-rc0
test-e2e2024/05/09 15:52:05 Upgrading node node 2 version v1.3.0
test-e2e2024/05/09 15:52:32 Upgrading node node 3 version v1.5.0
test-e2e2024/05/09 15:53:03 Upgrading node node 4 version v1.2.0
test-e2e2024/05/09 15:53:29 Upgrading node node 2 version v1.8.0
test-e2e2024/05/09 15:53:57 Upgrading node node 3 version v1.2.0
test-e2e2024/05/09 15:54:24 Upgrading node node 4 version v1.4.0
test-e2e2024/05/09 15:54:54 Upgrading node node 2 version v1.6.0
test-e2e2024/05/09 15:55:14 Upgrading node node 3 version v1.3.0
test-e2e2024/05/09 15:55:42 Upgrading node node 4 version v1.5.0
test-e2e2024/05/09 15:56:07 Upgrading node node 2 version v1.6.0

test-e2e2024/05/09 15:58:01 checking that all nodes are at the same height
test-e2e2024/05/09 15:58:07 --- ✅ PASS: MinorVersionCompatibility

[coderabbitai]

Walkthrough

The modifications primarily focus on extending the version compatibility tests in check_upgrades.go to include both v1 and v2 nodes by adjusting the version filtering logic. Additionally, there is a change in main.go where a constant declaration is altered, though its relation to version testing is not direct.

Changes

File Path	Change Summary
test/e2e/.../check_upgrades.go	Updated version filtering to include both v1 and v2 nodes by using new slices for each and concatenating them.
test/e2e/main.go	Removed reference to v1.Version from MajorVersion constant, replacing it with seed = 42.

Assessment against linked issues

Objective	Addressed	Explanation
Extend TestMinorVersionCompatibility to test v2 nodes (#3298)	✅

Possibly related issues

• Test celestia-node with celestia-app v2 #3420: The changes made to test both v1 and v2 nodes could help in verifying the compatibility between celestia-app v2 and celestia-node as described in the issue.
• Consider using v2.Version in process proposal tests #3013: Although the PR does not directly modify process proposal tests to use v2.Version, the adaptation of test environments to include v2 nodes aligns with the general direction of focusing on v2, which could be beneficial for future changes suggested in this issue.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.