Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register blob store key in v2 #3465

Merged
merged 1 commit into from
May 10, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented May 10, 2024

Closes #3464

@rootulp rootulp self-assigned this May 10, 2024
@rootulp rootulp requested a review from a team as a code owner May 10, 2024 19:33
@rootulp rootulp requested review from cmwaters and ninabarbakadze and removed request for a team May 10, 2024 19:33
Copy link
Contributor

coderabbitai bot commented May 10, 2024

Walkthrough

Walkthrough

The update in the code primarily involves the addition of several store keys (blobtypes.StoreKey, icahosttypes.StoreKey, packetforwardtypes.StoreKey, signaltypes.StoreKey) to ensure proper registration and functionality across different modules in the application. This is aimed at enhancing the modularity and versioning capabilities of the system.

Changes

File Changes
modules.go Added blobtypes.StoreKey, icahosttypes.StoreKey, packetforwardtypes.StoreKey, signaltypes.StoreKey to versionedStoreKeys function.

Assessment against linked issues

Objective Addressed Explanation
Register blob store key for v2 (#3464)
Ensure all new store keys are added to versioned list

Recent Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between a20edd1 and d7b03f2.
Files selected for processing (1)
  • app/modules.go (1 hunks)
Additional comments not posted (1)
app/modules.go (1)

328-339: The additions of icahosttypes.StoreKey, packetforwardtypes.StoreKey, and signaltypes.StoreKey to the versionedStoreKeys function for v2 are correctly implemented and align with the PR's objectives to ensure proper functionality in version 2 of the application.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@celestia-bot celestia-bot requested a review from a team May 10, 2024 19:34
@rootulp rootulp enabled auto-merge (squash) May 10, 2024 19:35
@rootulp rootulp requested review from rach-id and evan-forbes and removed request for cmwaters and ninabarbakadze May 10, 2024 19:35
@rootulp rootulp merged commit ea721d3 into celestiaorg:main May 10, 2024
34 checks passed
@rootulp rootulp deleted the rp/blob-store-key branch May 10, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blob store key missing for v2
3 participants