Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: consistent appHash between commits #3513
test: consistent appHash between commits #3513
Changes from 17 commits
91194da
3d65302
65d77c9
a3ca919
60861e3
0667101
28c24ff
c0452be
60edfd3
e0d91b2
11e55a2
7b4c1e1
7471b9a
c32926a
ae87db7
92be77f
7512217
d9e3a63
5e49042
8a6523e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace
panic
with proper error handling indeterministicKeyRing
.Using
panic
for error handling in test setups can lead to abrupt test terminations that are hard to debug. Consider returning an error from the function and usingrequire.NoError
in the test to handle these errors gracefully.Committable suggestion