test: backports knuu optimizations from 3493 #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staheri14
changed the title
staheri14
changed the title
staheri14
added
knuu
|
Since the optimization work was done by @smuu, assigning him to the PR for comments/questions. |
|
When this is merged, we can close #3480 |
…nto sanaz/backport-optimization-knuu
staheri14
changed the title
|
Let me know if you have any other questions about these optimizations. |
evan-forbes
approved these changes
Jun 19, 2024
|
[To reviewers] I ran all the e2e tests and benchmark tests using the current branch and can confirm that they all work fine. |
cmwaters
approved these changes
Jun 19, 2024
This was referenced Jun 19, 2024
This was referenced Sep 9, 2024
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3480
This PR backports many optimizations introduced in the big block tests via #3493 to the
mainbranch.Will be ready for review after merging #3514