-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(go.mod): bump grafana/pyroscope-go deps (backport #3849) #3854
Conversation
On Go 1.23 I got such failures: ``` % make build --> Updating go.mod --> Updating go.mod in ./test/interchain # github.com/grafana/pyroscope-go/godeltaprof/internal/pprof ../../../go/pkg/mod/github.com/grafana/pyroscope-go/[email protected]/internal/pprof/delta_mutex.go:30:20: undefined: runtime_cyclesPerSecond ../../../go/pkg/mod/github.com/grafana/pyroscope-go/[email protected]/internal/pprof/proto.go:320:8: undefined: runtime_expandFinalInlineFrame make: *** [build] Error 1 ``` Due to recent change in Go 1.23 where Go team removed some internal things. Simple bump works fine. (cherry picked from commit 2c74ea5) # Conflicts: # go.mod # go.sum
Cherry-pick of 2c74ea5 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Has merge conflicts + v2.1.2 is deployed to mainnet so we can probably stop backporting to v1.x |
On Go 1.23 I got such failures:
Due to recent change in Go 1.23 where Go team removed some internal things. Simple bump works fine.
This is an automatic backport of pull request #3849 done by Mergify.