fix(linter): replace loopvar linter

[kobakaku]

Closes #3918

Overview

Replase loopvar linter in the .golangci.yml.

TODO

Fix the lint error.
This issue needs to address the lint errors.

Test

--> Running golangci-lint
x/mint/client/testutil/suite_test.go:71:3: The copy of the 'for' variable "tc" can be deleted (Go 1.22+) (copyloopvar)
                tc := tc
                ^
x/mint/client/testutil/suite_test.go:106:3: The copy of the 'for' variable "tc" can be deleted (Go 1.22+) (copyloopvar)
                tc := tc
                ^
x/mint/client/testutil/suite_test.go:137:3: The copy of the 'for' variable "tc" can be deleted (Go 1.22+) (copyloopvar)
                tc := tc
                ^
x/blobstream/keeper/keeper_data_commitment.go:112:78: printf: non-constant format string in call to cosmossdk.io/errors.Wrapf (govet)
                        return types.DataCommitment{}, errors.Wrapf(types.ErrAttestationNotFound, fmt.Sprintf("nonce %d", i))
                                                                                                  ^
x/blobstream/keeper/keeper_data_commitment.go:139:61: printf: non-constant format string in call to cosmossdk.io/errors.Wrapf (govet)
                        return false, errors.Wrapf(types.ErrAttestationNotFound, fmt.Sprintf("nonce %d", i))
                                                                                 ^
x/blobstream/keeper/keeper_valset_test.go:60:3: The copy of the 'for' variable "spec" can be deleted (Go 1.22+) (copyloopvar)
                spec := spec
                ^
app/test/priority_test.go:83:3: The copy of the 'for' variable "accName" can be deleted (Go 1.22+) (copyloopvar)
                accName := accName // new variable per iteration
                ^
pkg/da/data_availability_header_test.go:91:3: The copy of the 'for' variable "tt" can be deleted (Go 1.22+) (copyloopvar)
                tt := tt
                ^
pkg/da/data_availability_header_test.go:125:3: The copy of the 'for' variable "tt" can be deleted (Go 1.22+) (copyloopvar)
                tt := tt
                ^
pkg/da/data_availability_header_test.go:206:3: The copy of the 'for' variable "tt" can be deleted (Go 1.22+) (copyloopvar)
                tt := tt
                ^
x/mint/simulation/decoder_test.go:54:3: The copy of the 'for' variable "i" can be deleted (Go 1.22+) (copyloopvar)
                i, tt := i, tt
                ^
make: *** [Makefile:105: lint] Error 1

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the .golangci.yml configuration file by removing the deprecated linter exportloopref and adding the linter copyloopvar. The settings for the nakedret linter remain unchanged, continuing to enforce a maximum function line limit of 0, which disallows naked returns.

Changes

File	Change Summary
.golangci.yml	Removed exportloopref and added copyloopvar in the linters section.

Assessment against linked issues

Objective	Addressed	Explanation
Resolve the warning about 'exportloopref' being deprecated ( #3918)	✅

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 66e5511 and 4cfc999.

📒 Files selected for processing (1)

• .golangci.yml (1 hunks)

🔇 Additional comments (3)

.golangci.yml (3)

Line range hint 1-22: Confirmation: No additional changes required

I've reviewed the entire file, and I can confirm that no other sections require updates due to the linter change. The run section and the linters-settings for nakedret remain relevant and do not conflict with the new copyloopvar linter.

---

Line range hint 1-22: Summary: Successful update of linter configuration

The changes made to .golangci.yml successfully address the PR objectives by replacing the deprecated exportloopref linter with the recommended copyloopvar linter. This update ensures compatibility with Go 1.22 and later versions, resolving the deprecation warning mentioned in issue #3918.

The modification is minimal and focused, affecting only the necessary part of the configuration. The linting process should now run without warnings related to deprecated linters, maintaining the project's code quality and compliance with the latest Go standards.

---

7-7: LGTM: Correct replacement of deprecated linter

The addition of copyloopvar to replace the deprecated exportloopref linter is correct and aligns with the PR objectives. This change addresses the deprecation warning and ensures compatibility with Go 1.22 and later versions.

To ensure the change is complete, let's verify that exportloopref has been completely removed:

✅ Verification successful

LGTM: Deprecated linter successfully removed

The removal of exportloopref from .golangci.yml has been successfully verified. This change aligns with the PR objectives and ensures compatibility with Go 1.22 and later versions.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that 'exportloopref' is not present in the .golangci.yml file

if grep -q "exportloopref" .golangci.yml; then
  echo "Warning: 'exportloopref' is still present in .golangci.yml"
else
  echo "Verification passed: 'exportloopref' has been completely removed"
fi

Length of output: 182

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rootulp]

Thanks!

Testing

$ make lint
--> Running golangci-lint

I don't see the warning anymore so this LGTM.

[kobakaku]

The content of this PR includes the PR