-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(specs): add missing versioned consts #4054
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4f26e6a
docs(specs): add missing versioned consts
rootulp be6a63a
Update specs/src/parameters_v1.md
rootulp e97e996
Update specs/src/parameters_v2.md
rootulp 9d87c1e
Update specs/src/parameters_v3.md
rootulp bace653
Update specs/src/parameters_v3.md
rootulp 77053b7
Update specs/src/parameters_v3.md
rootulp 39f2644
improve comments
rootulp 879a427
prettify tables
rootulp 08cb556
Merge branch 'main' into rp/versioned-const-specs
rootulp c5a916d
deprecate consts
rootulp 46d4a55
Merge branch 'main' into rp/versioned-const-specs
rootulp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Parameter naming inconsistency detected -
MaxSquareSize
vsSquareSizeUpperBound
The codebase shows inconsistency between the documented parameter name and its implementation:
SquareSizeUpperBound
in the specsMaxSquareSize
andGovMaxSquareSize
in the implementationSubtreeRootThreshold
parameter is consistently used and matches the documentationMiB
unit formatting is consistently used across the spec files🔗 Analysis chain
LGTM: Clear and well-documented parameter definitions
The changes improve clarity and completeness:
SquareSizeUpperBound
is a more descriptive name than the previousMaxSquareSize
SubtreeRootThreshold
parameter with proper ADR referenceMaxBlockSizeBytes
Let's verify the consistency of these parameter names across the codebase:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 16613