fix: typographical errors in multiple files #4078
Conversation
…b-fraud-proofs.md
dramarereg
requested review from
cmwaters and
ninabarbakadze
and removed request for
a team
📝 WalkthroughWalkthroughThe pull request includes modifications across several files, primarily addressing typographical errors in comments and documentation. Key changes involve correcting the spelling of "PrepareProposal" in multiple locations and updating the status of proposed optimizations in architectural documents. Additionally, a new governance parameter, Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
docs/architecture/adr-021-restricted-block-size.md (1)
109-109: Improve comment formatting for better readabilityThe line is too long and wraps awkwardly. Consider breaking it into multiple lines for better readability.
- // of the sdk and comet that have full support of PrepareProposal, although + // of the SDK and Comet that have full support of PrepareProposal, although + // celestia-app does not currently use those. See this PR for more details: + // https://github.com/cosmos/cosmos-sdk/pull/14505specs/src/cat_pool.md (1)
63-63: Enhance clarity of the SeenTx broadcasting requirementThe current wording could be more precise to emphasize this critical requirement.
-The `SeenTx` message MUST only be broadcasted after validation and storage. +The `SeenTx` message MUST only be broadcasted after successful validation and confirmed storage of the transaction.docs/architecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfb-fraud-proofs.md (1)
54-54: Maintain consistent list formattingThe line breaks the bullet point formatting pattern of the list.
-- how long the blob is +- length of the blobx/tokenfilter/README.md (1)
10-10: Consider adding a comma after 'Thus'.For improved readability and proper grammar, consider adding a comma after the conjunctive adverb "Thus".
-Thus tokens moved to a non-native state machine are beholden to the security of both chains. +Thus, tokens moved to a non-native state machine are beholden to the security of both chains.🧰 Tools
🪛 LanguageTool
[uncategorized] ~10-~10: A comma may be missing after the conjunctive/linking adverb ‘Thus’.
Context: ...n chain minting a "wrapped" equivalent. Thus tokens moved to a non-native state mach...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (7)
app/square_size.go(1 hunks)docs/architecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfb-fraud-proofs.md(1 hunks)docs/architecture/adr-021-restricted-block-size.md(1 hunks)specs/src/cat_pool.md(1 hunks)x/blob/ante/blob_share_decorator.go(1 hunks)x/blob/ante/max_total_blob_size_ante.go(1 hunks)x/tokenfilter/README.md(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- x/blob/ante/max_total_blob_size_ante.go
- app/square_size.go
- x/blob/ante/blob_share_decorator.go
🧰 Additional context used
🪛 LanguageTool
x/tokenfilter/README.md
[uncategorized] ~10-~10: A comma may be missing after the conjunctive/linking adverb ‘Thus’.
Context: ...n chain minting a "wrapped" equivalent. Thus tokens moved to a non-native state mach...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
🔇 Additional comments (1)
x/tokenfilter/README.md (1)
10-10: LGTM! Correct terminology used.
The term "beholden" is appropriately used in this context, accurately describing the security relationship between chains in IBC token transfers.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~10-~10: A comma may be missing after the conjunctive/linking adverb ‘Thus’.
Context: ...n chain minting a "wrapped" equivalent. Thus tokens moved to a non-native state mach...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
rootulp
changed the title
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Corrected the following typographical errors in various files:
square_size.goadr-021-restricted-block-size.mdmax_total_blob_size_ante.goblob_share_decorator.gocat_pool.mdadr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfb-fraud-proofs.mdREADME.mdChanges made: