refactor: export test chain id

[rootulp]

Closes #4070

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes in this pull request focus on enhancing the benchmarking and testing capabilities related to IBC client updates and application upgrades. New benchmark functions have been added to evaluate IBC transaction processing under different validator counts, and the hardcoded chain ID has been replaced with a constant for improved configurability. Additionally, various test cases have been updated to utilize this constant, ensuring consistency across the codebase. Overall, the modifications aim to standardize the testing approach and improve the reliability of the benchmarks.

Changes

File Path	Change Summary
app/benchmarks/benchmark_ibc_update_client_test.go	Added benchmark functions for IBC client updates and replaced hardcoded chain ID with appconsts.TestChainID.
app/test/upgrade_test.go	Updated TestAppUpgradeV3 to validate upgrades and replaced hardcoded chain ID with appconsts.TestChainID.
pkg/appconsts/chain_ids.go	Added constant TestChainID for use in testing scenarios.
pkg/appconsts/versioned_consts.go	Modified UpgradeHeightDelay to use TestChainID instead of a hardcoded string.
pkg/appconsts/versioned_consts_test.go	Updated test cases in TestUpgradeHeightDelay to use appconsts.TestChainID.
test/e2e/benchmark/throughput.go	Updated bigBlockManifest to use appconsts.TestChainID instead of a hardcoded string.
x/signal/integration_test.go	Replaced hardcoded chain ID with appconsts.TestChainID in TestUpgradeIntegration.
x/signal/keeper_test.go	Updated context block height calculations to use appconsts.TestChainID.

Assessment against linked issues

Objective	Addressed	Explanation
Use a constant name for "test" chain ID (#4070)	✅

Possibly related PRs

• chore: ABCI methods benchmarks #3904: This PR enhances the benchmarking tests for IBC client updates, which directly relates to the changes made in the main PR that also modifies benchmarking functions for IBC transactions.
• feat!: version UpgradeHeightDelay #3980: This PR introduces modifications to the UpgradeHeightDelay function, which is relevant as the main PR also involves changes to the handling of upgrade delays in the context of benchmarking tests.
• fix!: v3 upgrade delay #4008: This PR focuses on fixing the upgrade delay logic, which is closely related to the changes in the main PR that adjust how upgrade delays are calculated in benchmarking tests.
• refactor: override the upgrade height for chain-id test to 3 #4065: This PR modifies the upgrade height for the chain ID test, which is pertinent as the main PR also deals with benchmarking tests that may utilize this chain ID for testing purposes.

Suggested labels

enhancement, WS: Maintenance 🔧

Suggested reviewers

• cmwaters
• evan-forbes
• ninabarbakadze

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5edec3d and a9c8c64.

📒 Files selected for processing (1)

• pkg/appconsts/chain_ids.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/appconsts/chain_ids.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cmwaters]

Nice clean up