New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tx client concurrency test #4104

Draft

cmwaters wants to merge 1 commit into main from cal/concurrent_tx_client

Contributor

cmwaters commented Dec 10, 2024 •

edited

Loading

This PR makes two small tweaks:

Fixes TestConcurrentTxSubmission by adding a capacity of 1 to the errCh. Currently errors were being ignored because the wait group meant that there wasn't a process to read to the channel as it was being written to. This fixes this
Catches the case where a user cancels the context when calling ConfirmTx

This test is broken until celestiaorg/celestia-core#1553 is resolved


          fix: tx client concurrency test

c911c8f

rootulp assigned cmwaters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet