chore: use errors.New to replace fmt.Errorf with no parameters

[ChengenH]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request involve modifications to error handling in two Go files: params.go and minter.go. The errors package is imported in both files, replacing the use of fmt.Errorf with errors.New for creating error messages. This adjustment is made in specific validation functions and the Validate method, simplifying the error creation process while preserving the existing logic and control flow.

Changes

File	Change Summary
x/blob/types/params.go	Replaced fmt.Errorf with errors.New in validateGasPerBlobByte and validateGovMaxSquareSize for error messages.
x/mint/types/minter.go	Changed error handling in Validate method to use errors.New instead of fmt.Errorf for empty BondDenom.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Minter
    participant Params

    User->>Minter: Call Validate()
    Minter->>Minter: Check BondDenom
    alt BondDenom is empty
        Minter-->>User: Return errors.New("bond denom cannot be empty")
    end

    User->>Params: Call validateGasPerBlobByte()
    Params->>Params: Check GasPerBlobByte
    alt GasPerBlobByte is 0
        Params-->>User: Return errors.New("gas per blob byte cannot be 0")
    end

    User->>Params: Call validateGovMaxSquareSize()
    Params->>Params: Check GovMaxSquareSize
    alt GovMaxSquareSize is 0
        Params-->>User: Return errors.New("gov max square size cannot be zero")
    end

Loading

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad3a7fa and 6285203.

📒 Files selected for processing (2)

• x/blob/types/params.go (3 hunks)
• x/mint/types/minter.go (2 hunks)

🔇 Additional comments (5)

x/blob/types/params.go (3)

4-4: LGTM: Clean import addition

Clean addition of the errors package for the new error handling approach.

---

71-71: LGTM: Appropriate use of errors.New

Good replacement of fmt.Errorf with errors.New for a static error message.

---

85-85: LGTM: Appropriate use of errors.New

Good replacement of fmt.Errorf with errors.New for a static error message.

x/mint/types/minter.go (2)

4-4: LGTM: Clean import addition

Clean addition of the errors package for the new error handling approach.

---

37-37: LGTM: Appropriate use of errors.New

Good replacement of fmt.Errorf with errors.New for a static error message.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rootulp]

IMO this is a style choice. I would prefer if a linter was configured so that the codebase always used fmt.Errorf so that this codebase is consistent.

IMO if it's a style choice and it isn't enforced via a linter then I'm inclined to not merge this b/c nothing prevents a future PR from using fmt.Errorf without arguments.