-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: override timeout commit via --timeout-commit
(backport #4103)
#4114
Conversation
Closes #4080 ## Testing 1. `./scripts/single-node.sh` now makes blocks faster 🎊 2. `./scripts/arabica.sh` throws an error if you try to add `--timeout-commit 1s` ``` Error: the --timeout-commit flag was used on arabica-11 but it is unsupported on public networks: arabica-11, mocha-4, celestia. The --timeout-commit flag should only be used on private testnets. ``` (cherry picked from commit d20916c) # Conflicts: # cmd/celestia-appd/cmd/start.go # scripts/single-node.sh
Cherry-pick of d20916c has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically Go API breaking b/c app.New()
has an additional parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically Go API breaking b/c app.New() has an additional parameter.
You could probably do this in a non-breaking way by utilising baseapp options, but I think we can allow this to slide - I can't imagine there are too many users of the app.New() but good to avoid this if we can in the future
Closes #4080
Testing
./scripts/single-node.sh
now makes blocks faster 🎊./scripts/arabica.sh
throws an error if you try to add--timeout-commit 1s