Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix typos #4290

Merged
merged 3 commits into from
Feb 4, 2025
Merged

refactor: fix typos #4290

merged 3 commits into from
Feb 4, 2025

Conversation

Dimitrolito
Copy link
Contributor

  • Fixed incorrect variable name in app.go:

    • tokenFilterMiddelwaretokenFilterMiddleware to maintain proper naming consistency.
  • Corrected function name in consistent_apphash_test.go:

    • msgCreatePermamentLockedAccountmsgCreatePermanentLockedAccount to match the intended function definition.
  • Updated incorrect variable name in gov_params_test.go:

    • gotQuroumgotQuorum to align with correct terminology in governance tally parameters.

@Dimitrolito Dimitrolito requested a review from a team as a code owner February 4, 2025 12:14
@Dimitrolito Dimitrolito requested review from cmwaters and evan-forbes and removed request for a team February 4, 2025 12:14
Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

📝 Walkthrough

Walkthrough

This pull request addresses typographical errors by renaming variables across multiple Go files. The changes correct the names to follow standard conventions without altering the underlying functionality or control flow. The modifications occur in the main application, a test for SDK messages, and a governance parameter test.

Changes

Files Change Summary
app/app.go, app/test/consistent_apphash_test.go, x/paramfilter/test/gov_params_test.go Corrected typographical errors in variable names:
- tokenFilterMiddelwaretokenFilterMiddleware
- msgCreatePermamentLockedAccountmsgCreatePermanentLockedAccount
- gotQuroumgotQuorum

Possibly related PRs

  • fix: multiple typos #4117: Involved similar variable name corrections in app/app.go, aligning with the changes made in this pull request.

Suggested labels

external

Suggested reviewers

  • cmwaters
  • evan-forbes
  • rach-id
  • rootulp
  • ninabarbakadze

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a3d162 and 1083ca3.

📒 Files selected for processing (3)
  • app/app.go (1 hunks)
  • app/test/consistent_apphash_test.go (1 hunks)
  • x/paramfilter/test/gov_params_test.go (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • app/test/consistent_apphash_test.go
  • x/paramfilter/test/gov_params_test.go
  • app/app.go
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Summary

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rootulp rootulp changed the title docs(typo): correct misspelled variable and function names in core and test modules docs: fix typos Feb 4, 2025
@rootulp rootulp changed the title docs: fix typos refactor: fix typos Feb 4, 2025
@rootulp rootulp merged commit de7cab4 into celestiaorg:main Feb 4, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants