Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(blob): add links to inclusion and fraud proofs documentation #4298

Closed
wants to merge 5 commits into from
Closed

docs(blob): add links to inclusion and fraud proofs documentation #4298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b94f036
test(mint): add total supply verification in annual provisions test
VolodymyrBg Feb 5, 2025
660b4ca
docs(blob): add links to inclusion and fraud proofs documentation
VolodymyrBg Feb 5, 2025
3562802
Update x/mint/client/testutil/suite_test.go
VolodymyrBg Feb 5, 2025
bf15b57
Update x/mint/client/testutil/suite_test.go
VolodymyrBg Feb 5, 2025
688b75d
Update README.md
VolodymyrBg Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x/blob/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ in a block via a blob inclusion proof. A blob inclusion proof uses the
block's data square to prove to the user that the shares that compose their
original data do in fact exist in a particular block.

> TODO: link to blob inclusion (and fraud) proof
For detailed information about blob inclusion proofs and fraud proofs, see the [Fraud Proofs specification](../../specs/src/fraud_proofs.md) and [ADR-011: Optimistic Blob Size Independent Inclusion Proofs and PFB Fraud Proofs](../../docs/architecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfb-fraud-proofs.md).

## State

Expand Down
11 changes: 9 additions & 2 deletions x/mint/client/testutil/suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package testutil

import (
"context"
"fmt"
"strings"
"testing"
Expand All @@ -16,6 +17,7 @@ import (
sdk "github.com/cosmos/cosmos-sdk/types"

"github.com/celestiaorg/celestia-app/v3/test/util/testnode"
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
)

type IntegrationTestSuite struct {
Expand Down Expand Up @@ -81,9 +83,14 @@ func (s *IntegrationTestSuite) TestGetCmdQueryInflationRate() {
// TestGetCmdQueryAnnualProvisions tests that the CLI query command for annual-provisions
// returns the correct value. This test assumes that the initial inflation
// rate is 0.08 and the initial total supply is 500_000_000 utia.
//
// TODO assert that total supply is 500_000_000 utia.
func (s *IntegrationTestSuite) TestGetCmdQueryAnnualProvisions() {
// Verify that the initial total supply is 500_000_000 utia
bankClient := banktypes.NewQueryClient(s.cctx.Context)
resp, err := bankClient.TotalSupply(context.Background(), &banktypes.QueryTotalSupplyRequest{})
s.Require().NoError(err)
expectedTotalSupply := sdk.NewInt(500_000_000).Mul(sdk.NewInt(1_000_000)) // 500_000_000 utia
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails for me

--- FAIL: TestMintIntegrationTestSuite (11.20s)
    /Users/rootulp/git/rootulp/celestiaorg/celestia-app/x/mint/client/testutil/suite_test.go:35: setting up x/mint integration test suite
    --- FAIL: TestMintIntegrationTestSuite/TestGetCmdQueryAnnualProvisions (0.00s)
        /Users/rootulp/git/rootulp/celestiaorg/celestia-app/x/mint/client/testutil/suite_test.go:92: 
            	Error Trace:	/Users/rootulp/git/rootulp/celestiaorg/celestia-app/x/mint/client/testutil/suite_test.go:92
            	Error:      	Not equal: 
            	            	expected: "500000000000000"
            	            	actual  : "1000000028176989"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-500000000000000
            	            	+1000000028176989
            	Test:       	TestMintIntegrationTestSuite/TestGetCmdQueryAnnualProvisions
    /Users/rootulp/git/rootulp/celestiaorg/celestia-app/x/mint/client/testutil/network.go:48: tearing down testnode

s.Require().Equal(expectedTotalSupply.String(), resp.Supply.AmountOf("utia").String())
VolodymyrBg marked this conversation as resolved.
Show resolved Hide resolved

testCases := []struct {
name string
args []string
Expand Down
Loading