Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test to build random blocks and check if they're valid #715

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Sep 15, 2022

closes #588

see comment

@evan-forbes evan-forbes self-assigned this Sep 15, 2022
@evan-forbes evan-forbes added the testing items that are strictly related to adding or extending test coverage label Sep 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #715 (3d2369b) into main (7bbb270) will increase coverage by 1.69%.
The diff coverage is 64.60%.

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
+ Coverage   44.52%   46.22%   +1.69%     
==========================================
  Files          32       33       +1     
  Lines        3189     3217      +28     
==========================================
+ Hits         1420     1487      +67     
+ Misses       1666     1619      -47     
- Partials      103      111       +8     
Impacted Files Coverage Δ
pkg/prove/querier.go 0.00% <0.00%> (ø)
pkg/shares/utils.go 4.08% <0.00%> (+4.08%) ⬆️
pkg/prove/proof.go 82.48% <73.68%> (-1.35%) ⬇️
pkg/shares/split_compact_shares.go 84.00% <77.77%> (+13.59%) ⬆️
pkg/shares/share_merging.go 70.78% <80.00%> (ø)
pkg/shares/split_sparse_shares.go 69.51% <90.00%> (ø)
pkg/da/data_availability_header.go 78.68% <100.00%> (ø)
pkg/shares/parse_compact_shares.go 77.77% <100.00%> (ø)
pkg/shares/parse_sparse_shares.go 88.60% <100.00%> (ø)
pkg/shares/share_splitting.go 60.24% <100.00%> (+46.98%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rootulp
rootulp previously approved these changes Sep 15, 2022
testutil/payment/testutil.go Outdated Show resolved Hide resolved
@evan-forbes evan-forbes merged commit 27632dd into main Sep 16, 2022
@evan-forbes evan-forbes deleted the evan/NID-1-Fuzz-PrepareProcessProposal branch September 16, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement a fuzzing test for PrepareProposal and ProcessProposal
3 participants