Code

fix: set reserved byte correctly#818

Code

Closed

rootulp wants to merge 43 commits intocelestiaorg:maincelestiaorg/celestia-app:mainfrom rootulp:rp/fix-reserved-byterootulp/celestia-app:rp/fix-reserved-byteCopy head branch name to clipboard

+246-76

Commits

Commits on Sep 23, 2022

• wip: write data length to first compact share

  rootulp

  committed
  f93266b

Commits on Sep 26, 2022

• refactor: extract NumberOfBytesVarint

  rootulp

  committed
  e9848f2

• fix: TestCompactShareWriter

  rootulp

  committed
  6f879fe

• rename: txLen to unitLen. improve docs

  rootulp

  committed
  a15cff4

• fix: TestCount

  rootulp

  committed
  1ce5bad

• feat: introduce CompactStartShareContentSize

  rootulp

  committed
  b287b3f

• fix: all tests cases of TestTxSharePosition but one

  rootulp

  committed
  55dd412

• fix: joinByteSlice impl

  rootulp

  committed
  11027e9

• Merge branch 'rp/fix-proof-test' into rp/data-length-prefix

  rootulp

  committed
  4a97567

• bug: some tests fail b/c last byte of tx is not included in tx range

  rootulp

  committed
  d88a0c1

• rename: ContinuationCompactShareContentSize

  rootulp

  committed
  d9c507f

• Merge branch 'main' into rp/data-length-prefix

  rootulp

  committed
  14d8ccd

Commits on Sep 27, 2022

• chore: more test cases for TestTxShareIndex

  rootulp

  committed
  bbcfd16

• discovered bug in compact share splitting

  rootulp

  committed
  1229433

• reorder consts to use order in which they are encoded

  rootulp

  committed
  753779d

• remove duplicate unnecessary test

  rootulp

  committed
  676cee1

• implement failing test for SplitTxs

  rootulp

  committed
  1393238

Commits on Sep 28, 2022

• Merge branch 'main' into rp/data-length-prefix

  rootulp

  committed
  b6a9966

• pass TestSplitTxs with one transaction

  rootulp

  committed
  ac1ac10

• add test case for two transactions

  rootulp

  committed
  92202a5

• add test names

  rootulp

  committed
  e35f613

• replace hard-coded padding with bytes.Repeat

  rootulp

  committed
  3bc2389

• replace hard-coded padding with bytes.Repeat for test case 2

  rootulp

  committed
  181c118

• use bytes.Repeat for third test case

  rootulp

  committed
  3be79dc

• reserve byte should be non-zero

  rootulp

  committed
  ea1f7ce

• Merge branch 'main' into rp/data-length-prefix

  rootulp

  committed
  28e4606

• improve test name

  rootulp

  committed
  7e86c15

• implement failing fourth test case

  rootulp

  committed
  72713a3

• fix: test case four

  rootulp

  committed
  d6c0c9e

• uncomment proof tests

  rootulp

  committed
  9f44876

• remove unused helper, improve comments

  rootulp

  committed
  1452acf

• use css.isEmpty()

  rootulp

  committed
  4f38d3e

• remove debug logging

  rootulp

  committed
  4fd8493

• spin out txLen rename

  rootulp

  committed
  5b5d535

• revert namespace rename

  rootulp

  committed
  8361113

Commits on Sep 29, 2022

• chore: move zeroPadIfNecessary to utils (celestiaorg#811)

  Show description for fca6cd5
  rootulp

  committed
  fca6cd5

• Rename InfoReservedByte to InfoByte (celestiaorg#805)

  Show description for 537d091
  rootulp

  committed
  537d091

• test: transaction splitting (celestiaorg#813)

  Show description for c650400
  rootulp

  committed
  c650400

• chore: rename txLen to unitLen (celestiaorg#814)

  Show description for c02ef12
  rootulp

  committed
  c02ef12

• Merge branch 'main' into rp/data-length-prefix

  rootulp

  committed
  c952795

• feat!: stop forcing reserved byte to zero

  Show description for 2ee86a4
  rootulp

  committed
  2ee86a4

• fix: reserved byte for existing test cases

  rootulp

  committed
  dbe60c7

• test: add test case for reserved byte that is not 14

  rootulp

  committed
  f781496