Update docs for payment module #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
force-pushed
the
rp/payment-docs-2
branch
from
e7da90c to
cf088a9
Compare
rootulp
commented
Nov 4, 2022
rach-id
approved these changes
Nov 4, 2022
| ## Messages | ||
|
|
||
| - [`MsgWirePayForData`](https://github.com/celestiaorg/celestia-app/blob/b4c8ebdf35db200a9b99d295a13de01110802af4/x/payment/types/tx.pb.go#L32-L40) | ||
| The payment module doesn't maintain it's own state. |
There was a problem hiding this comment.
Suggested change
| The payment module doesn't maintain it's own state. | |
| The payment module doesn't maintain its own state. |
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
## TODO - [x] Split out changes that are only relevant post ADR 008 implementation and target feature branch - [x] Document gas cost for a message - [x] [Potentially] remove outdated code blocks from README.md ## Future PRs - [ ] Params section needs to be updated after params are added to payment module celestiaorg#893 - [ ] [Potentially] add client section (motivated by https://github.com/cosmos/cosmos-sdk/tree/main/x/auth#client)
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
## TODO - [x] Split out changes that are only relevant post ADR 008 implementation and target feature branch - [x] Document gas cost for a message - [x] [Potentially] remove outdated code blocks from README.md ## Future PRs - [ ] Params section needs to be updated after params are added to payment module celestiaorg#893 - [ ] [Potentially] add client section (motivated by https://github.com/cosmos/cosmos-sdk/tree/main/x/auth#client)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Future PRs