chore!: rename payment module -> blob #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
C: Celestia app
chore
|
Blob in a generic context as a replacement for payment sounds a little confusing to me, but if there's general consensus for renaming it to blob |
rootulp
approved these changes
Nov 8, 2022
| @@ -58,7 +58,7 @@ func (k Keeper) DeserializeValidatorIterator(vals []byte) stakingtypes.ValAddres | |||
| return validators | |||
| } | |||
|
|
|||
| // StakingKeeper restricts the functionality of the bank keeper used in the payment keeper | |||
| // StakingKeeper restricts the functionality of the bank keeper used in the qgb keeper | |||
|
|
|
@evan-forbes The test |
Codecov Report
@@ Coverage Diff @@
## main #972 +/- ##
==========================================
+ Coverage 26.13% 29.74% +3.61%
==========================================
Files 77 72 -5
Lines 9353 8199 -1154
==========================================
- Hits 2444 2439 -5
+ Misses 6680 5531 -1149
Partials 229 229
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
yeah I've started, #988 it might be anecdotal, but it seems to fail a lot more often when we are running the CI in different PRs at once. It also started to when we decreased the block time. |
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
speak now or forever hold your peace. NOTE: this PR does not rename MsgPayForData or MsgWirePayForData, as this was already too big of a diff. closes celestiaorg#961
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
speak now or forever hold your peace. NOTE: this PR does not rename MsgPayForData or MsgWirePayForData, as this was already too big of a diff. closes celestiaorg#961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
speak now or forever hold your peace.
NOTE: this PR does not rename MsgPayForData or MsgWirePayForData, as this was already too big of a diff.
closes #961