don't post the data to ipfs until after the proposal is made. Set Tim…

…eout to 1.5 seconds

wrap error instead of panicking

consensus/state.go

@@ -1077,16 +1077,6 @@ func (cs *State) defaultDecideProposal(height int64, round int32) {
 		if block == nil {
 			return
 		}
-		// post data to ipfs
-		// TODO(evan): don't hard code context
-		if cs.IpfsAPI != nil {
-			ctx, cancel := context.WithTimeout(context.Background(), time.Second)
-			err := block.PutBlock(ctx, cs.IpfsAPI.Dag().Pinning())
-			if err != nil {
-				cs.Logger.Error(fmt.Sprintf("failure to post block data to IPFS: %s", err.Error()))
-			}
-			cancel()
-		}
 	}
 
 	// Flush the WAL. Otherwise, we may not recompute the same proposal to sign,
@@ -1113,6 +1103,19 @@ func (cs *State) defaultDecideProposal(height int64, round int32) {
 	} else if !cs.replayMode {
 		cs.Logger.Error("enterPropose: Error signing proposal", "height", height, "round", round, "err", err)
 	}
+
+	// post data to ipfs
+	// TODO(evan): don't hard code context and timeout
+	if cs.IpfsAPI != nil {
+		// longer timeouts result in block proposers failing to propose blocks in time.
+		ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond*1500)
+		// TODO: post data to IPFS in a goroutine
+		err := block.PutBlock(ctx, cs.IpfsAPI.Dag().Pinning())
+		if err != nil {
+			cs.Logger.Error(fmt.Sprintf("failure to post block data to IPFS: %s", err.Error()))
+		}
+		cancel()
+	}
 }
 
 // Returns true if the proposal block is complete &&

types/block.go

@@ -282,7 +282,7 @@ func (b *Block) PutBlock(ctx context.Context, api format.NodeAdder) error {
 	// recompute the eds
 	eds, err := rsmt2d.ComputeExtendedDataSquare(shares, rsmt2d.RSGF8, rsmt2d.NewDefaultTree)
 	if err != nil {
-		panic(fmt.Sprintf("unexpected error: %v", err))
+		return fmt.Errorf("failure to recompute the extended data square: %w", err)
 	}
 
 	// add namespaces to erasured shares and flatten the eds