Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate config for timeout_commit and timeout_propose #1550

Closed
rootulp opened this issue Dec 9, 2024 · 0 comments · Fixed by #1551
Closed

Deprecate config for timeout_commit and timeout_propose #1550

rootulp opened this issue Dec 9, 2024 · 0 comments · Fixed by #1551
Assignees

Comments

@rootulp
Copy link
Collaborator

rootulp commented Dec 9, 2024

Context

celestiaorg/celestia-app#3882 made the config timeout_commit and timeout_propose unused in app version >= 3.

Motivation

celestiaorg/celestia-app#4080 (comment)

Problem

On main, if I run celestia-appd init then I see a config.toml like this:

# How long we wait for a proposal block before prevoting nil
timeout_propose = "3.5s"

# How long we wait after committing a block, before starting on the new
# height (this gives us a chance to receive some more precommits, even
# though we already have +2/3).
timeout_commit = "4.2s"

The config doesn't mention that these two fields are deprecated in v3.x and have no effect.

Proposal

Add a comment that says these fields are deprecated for app version >= 3.

@rootulp rootulp self-assigned this Dec 9, 2024
@rootulp rootulp transferred this issue from celestiaorg/celestia-app Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant